From e5a4cc630f6681d4455cbd34a9538687ca44bdd6 Mon Sep 17 00:00:00 2001 From: Eyal Date: Tue, 5 Mar 2019 16:07:12 +0200 Subject: [PATCH] small refactoring on graph creation and checks * copy is redundant remove it * use enumarate instead of index * use for each instead for on range Change-Id: I9cac993067e13b635733008d4ba866271b33cf29 --- vitrage_tempest_plugin/tests/base.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vitrage_tempest_plugin/tests/base.py b/vitrage_tempest_plugin/tests/base.py index 48c1347..725f1b7 100644 --- a/vitrage_tempest_plugin/tests/base.py +++ b/vitrage_tempest_plugin/tests/base.py @@ -288,7 +288,7 @@ class BaseVitrageTempest(test.BaseTestCase): graph = nx.MultiDiGraph() if not graph else graph if 'children' in api_graph: - children = api_graph.copy()['children'] + children = api_graph['children'] del api_graph['children'] vitrage_id = api_graph[VProps.VITRAGE_ID] @@ -306,13 +306,13 @@ class BaseVitrageTempest(test.BaseTestCase): graph = nx.MultiDiGraph() nodes = api_graph['nodes'] - for i in range(len(nodes)): - graph.add_node(str(i), **nodes[i]) + for i, node in enumerate(nodes): + graph.add_node(str(i), **node) edges = api_graph['links'] - for i in range(len(edges)): - graph.add_edge(str(edges[i]['source']), - str(edges[i]['target']), + for edge in edges: + graph.add_edge(str(edge['source']), + str(edge['target']), EdgeProperties.RELATIONSHIP_TYPE) return graph