2015-09-30 20:10:46 +00:00
|
|
|
vitrage Style Commandments
|
2015-12-20 08:26:53 +00:00
|
|
|
==========================
|
2015-09-30 20:10:46 +00:00
|
|
|
|
2017-08-24 07:01:00 +00:00
|
|
|
Read the OpenStack Style Commandments https://docs.openstack.org/hacking/latest/
|
2017-11-13 10:02:11 +00:00
|
|
|
|
|
|
|
Vitrage Specific Commandments
|
|
|
|
-----------------------------
|
|
|
|
|
|
|
|
[V316] assertTrue(isinstance(a, b)) sentences not allowed
|
|
|
|
[V317] assertEqual(type(A), B) sentences not allowed
|
|
|
|
[V318] assertEqual(A, None) or assertEqual(None, A) sentences not allowed
|
|
|
|
[V319] Don't translate logs
|
|
|
|
[V320] Use six.text_type() instead of unicode()
|
|
|
|
[V321] contextlib.nested is deprecated
|
|
|
|
[V322] use a dict comprehension instead of a dict constructor with a sequence of key-value pairs
|
|
|
|
[V323] Do not use xrange. Use range, or six.moves.range
|
|
|
|
[V324] Use six.iteritems() or dict.items() instead of dict.iteritems()
|
|
|
|
[V325] Use six.iterkeys() or dict.keys() instead of dict.iterkeys()
|
|
|
|
[V326] Use six.itervalues() or dict.values instead of dict.itervalues()
|
2017-11-20 09:24:26 +00:00
|
|
|
[V327] Method's default argument shouldn't be mutable
|
2018-01-03 08:26:42 +00:00
|
|
|
[V328] Disallow LOG.warn
|
|
|
|
[V329] Don't use assertEqual(True/False, observed).
|