From 060bdfdc10cab650326430ec71ade65610644852 Mon Sep 17 00:00:00 2001 From: Eyal Date: Sun, 14 Jan 2018 10:10:19 +0200 Subject: [PATCH] remove V318 hacking already implemented in infra hacking H203 Change-Id: Ibb3b1c94230bb39d4eeac46242b3206aad1a81d9 --- vitrage/hacking/checks.py | 13 ------------- vitrage/tests/unit/hacking/test_hacking.py | 10 ---------- 2 files changed, 23 deletions(-) diff --git a/vitrage/hacking/checks.py b/vitrage/hacking/checks.py index 778afef43..503d81d02 100644 --- a/vitrage/hacking/checks.py +++ b/vitrage/hacking/checks.py @@ -56,18 +56,6 @@ def assert_equal_type(logical_line): yield (0, "V317: assertEqual(type(A), B) sentences not allowed") -def assert_equal_none(logical_line): - """Check for assertEqual(A, None) or assertEqual(None, A) sentences - - V318 - """ - res = (asse_equal_start_with_none_re.match(logical_line) or - asse_equal_end_with_none_re.match(logical_line)) - if res: - yield (0, "V318: assertEqual(A, None) or assertEqual(None, A) " - "sentences not allowed") - - def no_translate_logs(logical_line): """Check for use of LOG.*(_( @@ -168,7 +156,6 @@ def factory(register): register(assert_true_instance) register(check_assert_true_false) register(assert_equal_type) - register(assert_equal_none) register(no_translate_logs) register(no_direct_use_of_unicode_function) register(no_mutable_default_args) diff --git a/vitrage/tests/unit/hacking/test_hacking.py b/vitrage/tests/unit/hacking/test_hacking.py index 0608b50d7..575821364 100644 --- a/vitrage/tests/unit/hacking/test_hacking.py +++ b/vitrage/tests/unit/hacking/test_hacking.py @@ -35,16 +35,6 @@ class HackingTestCase(base.BaseTest): self.assertEqual( 0, len(list(checks.assert_equal_type("self.assertTrue()")))) - def test_assert_equal_none(self): - self.assertEqual(1, len(list(checks.assert_equal_none( - "self.assertEqual(A, None)")))) - - self.assertEqual(1, len(list(checks.assert_equal_none( - "self.assertEqual(None, A)")))) - - self.assertEqual( - 0, len(list(checks.assert_equal_none("self.assertIsNone()")))) - def test_no_translate_logs(self): for log in checks._all_log_levels: bad = 'LOG.%s(_("Bad"))' % log