From 68a90b2cfad1f5abce422186b9675f5bad03ae19 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Fri, 22 Mar 2019 09:52:09 -0500 Subject: [PATCH] Fix lower-constraint deps handling When the lower-constraints tox target was added, it was assumed the install_command was just running the install and that the dependencies and constraints were being set using "deps = ". This fixed the install_command and deps to follow the expected pattern so the lower-constraints job actual does install the lower constraints. This also raises the oslo.context minimum as Ic96c1f1e1a80099d9dafa95a014fc47f05b88e42 added a dependency on a newer versions kwarg. Depends-On: https://review.openstack.org/#/c/647726/ Change-Id: I4cc2c3ac158a607b22295c50f83896969a4007ee Signed-off-by: Sean McGinnis --- lower-constraints.txt | 2 +- requirements.txt | 2 +- tox.ini | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lower-constraints.txt b/lower-constraints.txt index 99567f6bd..a0b468930 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -76,7 +76,7 @@ osc-lib==1.10.0 oslo.cache==1.29.0 oslo.concurrency==3.26.0 oslo.config==5.2.0 -oslo.context==2.20.0 +oslo.context==2.21.0 oslo.db==4.35.0 oslo.i18n==3.20.0 oslo.log==3.37.0 diff --git a/requirements.txt b/requirements.txt index 39d429b2c..4e3744a81 100644 --- a/requirements.txt +++ b/requirements.txt @@ -13,7 +13,7 @@ croniter>=0.3.20 # MIT License oslo.concurrency>=3.26.0 # Apache-2.0 oslo.cache>=1.29.0 # Apache-2.0 oslo.config>=5.2.0 # Apache-2.0 -oslo.context>=2.20.0 # Apache-2.0 +oslo.context>=2.21.0 # Apache-2.0 oslo.db>=4.35.0 # Apache-2.0 oslo.i18n>=3.20.0 # Apache-2.0 oslo.log>=3.37.0 # Apache-2.0 diff --git a/tox.ini b/tox.ini index ea2ae04d4..2ace72cf8 100644 --- a/tox.ini +++ b/tox.ini @@ -7,10 +7,13 @@ skipsdist = True usedevelop = True whitelist_externals = find rm -install_command = pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages} +install_command = pip install {opts} {packages} setenv = VIRTUAL_ENV={envdir} -deps = -r{toxinidir}/test-requirements.txt +deps = + -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} + -r{toxinidir}/test-requirements.txt + -r{toxinidir}/requirements.txt commands = rm -f .testrepository/times.dbm find . -type f -name "*.py[c|o]" -delete