From a9b90ca0036816c2a97f6283d363fa3bbcf39439 Mon Sep 17 00:00:00 2001 From: Douglas Viroel Date: Fri, 6 Feb 2026 12:16:01 -0300 Subject: [PATCH] Deprecate rollback_when_actionplan_failed configuration This configuraton option is associated to the revert of failed Action Plans, which isn't working for a long time and there is no plan on fixing it in the way that was originally designed. Related-Bug: #2122148 Change-Id: I9a568e7b1c0f70c78a9aa5e5f598b1e8a39f001f Signed-off-by: Douglas Viroel --- doc/source/contributor/concurrency.rst | 5 +++++ ...eprecate_actionplan_rollback_opt-9447a2b26bbe476e.yaml | 8 ++++++++ watcher/conf/applier.py | 6 +++++- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/deprecate_actionplan_rollback_opt-9447a2b26bbe476e.yaml diff --git a/doc/source/contributor/concurrency.rst b/doc/source/contributor/concurrency.rst index d33b14a3f..701fc7bd7 100644 --- a/doc/source/contributor/concurrency.rst +++ b/doc/source/contributor/concurrency.rst @@ -252,6 +252,11 @@ individual actions in the database. Additionally, since taskflow uses a graph flow if any of the tasks would fail all children of this tasks not be executed while ``do_revert`` will be triggered for all parents. +.. warning:: + + The revert of failed Actions functionality is deprecated and won't be + executed when using Taskflow as workflow engine. + .. code-block:: python class TaskFlowActionContainer(...): diff --git a/releasenotes/notes/deprecate_actionplan_rollback_opt-9447a2b26bbe476e.yaml b/releasenotes/notes/deprecate_actionplan_rollback_opt-9447a2b26bbe476e.yaml new file mode 100644 index 000000000..42d815e72 --- /dev/null +++ b/releasenotes/notes/deprecate_actionplan_rollback_opt-9447a2b26bbe476e.yaml @@ -0,0 +1,8 @@ +--- +deprecations: + - | + The rollback of Action Plans has not been working for a long time, + and there is no plan to fix it in the way that was originally designed. + The following configuration option, associated with this functionality, is + now deprecated for future removal: + - ``rollback_when_actionplan_failed`` diff --git a/watcher/conf/applier.py b/watcher/conf/applier.py index ac3ba0df3..318a86852 100644 --- a/watcher/conf/applier.py +++ b/watcher/conf/applier.py @@ -46,7 +46,11 @@ APPLIER_OPTS = [ cfg.BoolOpt('rollback_when_actionplan_failed', default=False, help='If set True, the failed actionplan will rollback ' - 'when executing. Default value is False.'), + 'when executing. Default value is False.', + deprecated_for_removal=True, + deprecated_since='2026.1', + deprecated_reason='This feature does not work and is planned ' + 'to be removed in future releases.'), ]