openstack
/
whitebox-tempest-plugin
Code Issues Proposed changes

Don't show server twice needlessly 

Previously, in get_server_xml(), we used to get the server twice, once
for the host, and once for the instance name. Stop doing that.

Change-Id: I1aedcd72757cf25c35ae505b6b63ff65616c51b8
This commit is contained in:
Artom Lifshitz 2021-12-01 18:52:11 -05:00 committed by Artom Lifshitz
parent 6679a3853a
commit f5b8464534
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
whitebox_tempest_plugin/api/compute/base.py
View File

@ -92,11 +92,10 @@ class BaseWhiteboxComputeTest(base.BaseV2ComputeAdminTest):
yield [stack.enter_context(mgr) for mgr in ctxt_mgrs]
def get_server_xml(self, server_id):
server = self.os_admin.servers_client.show_server(server_id)
host = server['server']['OS-EXT-SRV-ATTR:host']
server = self.os_admin.servers_client.show_server(server_id)['server']
host = server['OS-EXT-SRV-ATTR:host']
cntrlplane_addr = whitebox_utils.get_ctlplane_address(host)
server_instance_name = self.os_admin.servers_client.show_server(
server_id)['server']['OS-EXT-SRV-ATTR:instance_name']
server_instance_name = server['OS-EXT-SRV-ATTR:instance_name']
virshxml = clients.VirshXMLClient(cntrlplane_addr)
xml = virshxml.dumpxml(server_instance_name)