openstack/zaqar
Code Issues Proposed changes

Use issublcass instead of isinstance

Browse Source 
StorageBaseTest should check for issubclass instead of isinstance since
the driver / controller instances are not yet created at that time.

Fixes bug 1154690

Change-Id: I12a76305045cd7dfb8c98ece97e9e6c02e0b7622
This commit is contained in:
Flaper Fesp 2013-03-13 17:51:43 +01:00
parent 6864efb0cb
commit 64cfda6fa8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
marconi/tests/storage/base.py
View File

@ -29,7 +29,7 @@ class ControllerBaseTest(suite.TestSuite):
if not self.driver_class:
self.skipTest("No driver class specified")
if not isinstance(self.controller_class, self.controller_base_class):
if not issubclass(self.controller_class, self.controller_base_class):
self.skipTest("%s is not an instance of %s. Tests not supported" %
(self.controller_class, self.controller_base_class))