openstack/zaqar
Code Issues Proposed changes

fix: Reduce logging severity of certain errors

Browse Source 
Here are the proposed changes:
- OverflowedJsonInteger: exception -> debug
- InvalidJson: exception -> debug
- InvalidQueueName: warning -> debug

Rationale: these pollute the server logs and provide little value to
system operators.

Change-Id: Icd73a5bd3fc7d7ef349b18e7e485df8a7dfc0a1a
Closes-Bug: #1246977
This commit is contained in:
Alejandro Cabrera 2013-11-01 00:28:30 -04:00
parent ec18885d96
commit d5d2ef321b
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
marconi/common/transport/wsgi/helpers.py
View File

@ -75,9 +75,9 @@ def validate_queue_identification(validate, req, resp, params):
project = params['project_id']
queue = params['queue_name'].decode('utf-8', 'replace')
LOG.warn(_(u'Invalid queue name "%(queue)s" submitted for '
u'project: %(project)s'),
{'queue': queue, 'project': project})
LOG.debug(_(u'Invalid queue name "%(queue)s" submitted for '
u'project: %(project)s'),
{'queue': queue, 'project': project})
raise falcon.HTTPBadRequest(_(u'Invalid queue identification'),
_(u'The format of the submitted queue '

4
marconi/queues/transport/wsgi/utils.py
View File

@ -67,12 +67,12 @@ def filter_stream(stream, len, spec=None, doctype=JSONObject):
document = utils.read_json(stream, len)
except utils.MalformedJSON as ex:
LOG.exception(ex)
LOG.debug(ex)
description = _(u'Request body could not be parsed.')
raise errors.HTTPBadRequestBody(description)
except utils.OverflowedJSONInteger as ex:
LOG.exception(ex)
LOG.debug(ex)
description = _(u'JSON contains integer that is too large.')
raise errors.HTTPBadRequestBody(description)