openstack/zun
Code Issues Proposed changes

Pre-load the list of image drivers

Browse Source 
In before, we load the image drivers on demand. This is undesirable
because the image driver will be loaded per request which is
unnecessary. After this patch, the image drivers will be loaded
on initialization. Each request will retrieve the pre-loaded
driver instead.

Change-Id: If67610f27dc2fd1d95196b8cdb1e99bcb0f03080
This commit is contained in:
Hongbin Lu 2018-03-30 18:37:27 +00:00
parent eb5608c1cc
commit 0cd9cb4124
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
zun/container/docker/driver.py
View File

@ -102,6 +102,10 @@ class DockerDriver(driver.ContainerDriver):
self._host = host.Host()
self._get_host_storage_info()
self.volume_driver = vol_driver.driver()
self.image_drivers = {}
for driver_name in CONF.image_driver_list:
driver = img_driver.load_image_driver(driver_name)
self.image_drivers[driver_name] = driver
def _get_host_storage_info(self):
storage_info = self._host.get_storage_info()
@ -140,7 +144,7 @@ class DockerDriver(driver.ContainerDriver):
driver_name = CONF.default_image_driver
try:
image_driver = img_driver.load_image_driver(driver_name)
image_driver = self.image_drivers[driver_name]
image, image_loaded = image_driver.pull_image(
context, repo, tag, image_pull_policy)
if image:
@ -157,8 +161,11 @@ class DockerDriver(driver.ContainerDriver):
return image, image_loaded
def search_image(self, context, repo, tag, driver_name, exact_match):
if driver_name is None:
driver_name = CONF.default_image_driver
try:
image_driver = img_driver.load_image_driver(driver_name)
image_driver = self.image_drivers[driver_name]
return image_driver.search_image(context, repo, tag,
exact_match)
except Exception as e: