From c0d770a62f3d5e820706230dc4b049aca2dce6c8 Mon Sep 17 00:00:00 2001 From: Feng Shengqin Date: Mon, 15 Jan 2018 17:10:33 +0800 Subject: [PATCH] check the security group has been added to the container Change-Id: I06f60fceb6116d2bb7189426295757b5abe5598c --- zun/api/controllers/v1/containers.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/zun/api/controllers/v1/containers.py b/zun/api/controllers/v1/containers.py index 13dc608ba..344b46aa8 100644 --- a/zun/api/controllers/v1/containers.py +++ b/zun/api/controllers/v1/containers.py @@ -427,6 +427,10 @@ class ContainersController(base.Controller): context = pecan.request.context compute_api = pecan.request.compute_api security_group_id = self._check_security_group(context, security_group) + if security_group_id in container.security_groups: + msg = _("Security group %(id)s has been added to container.") % { + 'id': security_group_id} + raise exception.InvalidValue(msg) compute_api.add_security_group(context, container, security_group_id) pecan.response.status = 202