openinfra
/
openstackid
Code Issues Proposed changes

Fixed Scope Groups Update 

* fixed server error due a deprecated method
* refactoring

Change-Id: I25f193d54f0953d1e6dca19553874b0bfe69e947
This commit is contained in:
smarcet 2019-04-02 16:25:39 -03:00
parent 392dfd3214
commit 8d6fcb85cc
7 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/Http/Controllers/Api/ApiScopeGroupController.php
View File

@ -202,25 +202,24 @@ final class ApiScopeGroupController extends AbstractRESTController implements IC
$values = Input::all(); $values = Input::all();
$rules = array $rules = [
( 'id' => 'required|integer',
'id' => 'required|integer',
'name' => 'required|text|max:512', 'name' => 'required|text|max:512',
'active' => 'required|boolean', 'active' => 'required|boolean',
'scopes' => 'required', 'scopes' => 'required',
'users' => 'required|user_ids', 'users' => 'required|user_ids',
); ];
// Creates a Validator instance and validates the data. // Creates a Validator instance and validates the data.
$validation = Validator::make($values, $rules); $validation = Validator::make($values, $rules);
if ($validation->fails()) { if ($validation->fails()) {
$messages = $validation->messages()->toArray(); $messages = $validation->messages()->toArray();
return $this->error400(array('error' => 'validation', 'messages' => $messages)); return $this->error400(['error' => 'validation', 'messages' => $messages]);
} }
$res = $this->service->update(intval($values['id']), $values); $this->service->update(intval($values['id']), $values);
return $res ? $this->ok() : $this->error400(array('error' => 'operation failed')); return $this->ok();
} }
catch (InvalidApiScopeGroup $ex1) catch (InvalidApiScopeGroup $ex1)
{ {
@ -236,8 +235,8 @@ final class ApiScopeGroupController extends AbstractRESTController implements IC
public function activate($id){ public function activate($id){
try try
{ {
$res = $this->service->setStatus($id, true); $this->service->setStatus($id, true);
return $res?$this->ok():$this->error400(array('error'=>'operation failed')); return $this->ok();
} }
catch (Exception $ex) { catch (Exception $ex) {
$this->log_service->error($ex); $this->log_service->error($ex);
@ -248,8 +247,8 @@ final class ApiScopeGroupController extends AbstractRESTController implements IC
public function deactivate($id){ public function deactivate($id){
try try
{ {
$res = $this->service->setStatus($id, false); $this->service->setStatus($id, false);
return $res?$this->ok():$this->error400(array('error'=>'operation failed')); return $this->ok();
} }
catch (Exception $ex) { catch (Exception $ex) {
$this->log_service->error($ex); $this->log_service->error($ex);

1
app/Http/Controllers/Api/ClientApiController.php
View File

@ -240,7 +240,6 @@ final class ClientApiController extends AbstractRESTController implements ICRUDC
'policy_uri' => 'sometimes|required|url', 'policy_uri' => 'sometimes|required|url',
'jwks_uri' => 'sometimes|required|url', 'jwks_uri' => 'sometimes|required|url',
'default_max_age' => 'sometimes|required|integer', 'default_max_age' => 'sometimes|required|integer',
'logout_use_iframe' => 'sometimes|required|boolean',
'require_auth_time' => 'sometimes|required|boolean', 'require_auth_time' => 'sometimes|required|boolean',
'token_endpoint_auth_method' => 'sometimes|required|token_endpoint_auth_method', 'token_endpoint_auth_method' => 'sometimes|required|token_endpoint_auth_method',
'token_endpoint_auth_signing_alg' => 'sometimes|required|signing_alg', 'token_endpoint_auth_signing_alg' => 'sometimes|required|signing_alg',

2
app/Services/OAuth2/ApiScopeGroupService.php
View File

@ -112,7 +112,7 @@ final class ApiScopeGroupService implements IApiScopeGroupService
} }
if($param === 'scopes') if($param === 'scopes')
{ {
$ids = $group->scopes()->getRelatedIds()->all(); $ids = $group->scopes()->pluck('id')->all();
$group->scopes()->detach($ids); $group->scopes()->detach($ids);
$scopes = explode(',', $params['scopes']); $scopes = explode(',', $params['scopes']);
foreach($scopes as $scope_id) foreach($scopes as $scope_id)

3
app/libs/OAuth2/Models/AuthorizationCode.php
View File

@ -184,7 +184,8 @@ class AuthorizationCode extends Token
$value, $value,
$user_id, $user_id,
$client_id, $client_id,
$scope,$audience = '', $scope,
$audience = '',
$redirect_uri = null, $redirect_uri = null,
$issued = null, $issued = null,
$lifetime = 600, $lifetime = 600,

1
app/libs/Utils/Http/HttpResponse.php
View File

@ -23,6 +23,7 @@ abstract class HttpResponse extends HttpMessage
*/ */
public function __construct($http_code, $content_type) public function __construct($http_code, $content_type)
{ {
parent::__construct();
$this->http_code = $http_code; $this->http_code = $http_code;
$this->content_type = $content_type; $this->content_type = $content_type;
} }

7
database/seeds/ApiSeeder.php
View File

@ -20,10 +20,9 @@ class ApiSeeder extends Seeder {
// users // users
Api::create( Api::create(
array( array(
'name' => 'users', 'name' => 'users',
'logo' => null, 'active' => true,
'active' => true, 'Description' => 'User Info',
'Description' => 'User Info',
'resource_server_id' => $resource_server->id, 'resource_server_id' => $resource_server->id,
'logo' => asset('/assets/img/apis/server.png') 'logo' => asset('/assets/img/apis/server.png')
) )

1
tests/OAuth2ProtocolTest.php
View File

@ -654,7 +654,6 @@ final class OAuth2ProtocolTest extends OpenStackIDBaseTest
$params = array( $params = array(
'refresh_token' => $refresh_token, 'refresh_token' => $refresh_token,
'grant_type' => OAuth2Protocol::OAuth2Protocol_GrantType_RefreshToken, 'grant_type' => OAuth2Protocol::OAuth2Protocol_GrantType_RefreshToken,
'grant_type' => OAuth2Protocol::OAuth2Protocol_GrantType_RefreshToken,
); );
$response = $this->action("POST", "OAuth2\OAuth2ProviderController@token", $response = $this->action("POST", "OAuth2\OAuth2ProviderController@token",