Update patch set 2
Patch Set 2: Code-Review-1 (2 comments) minor nit regarding hacking rules on how we organize imports. Patch-set: 2 Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
35fbc6b1a9
commit
2e38144c86
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "cac0be2c_1e81a705",
|
||||
"filename": "refstack/tests/api/test_products.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2021-01-22T18:14:52Z",
|
||||
"side": 1,
|
||||
"message": "unittest is part of the standard library, so belongs in the group above..",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 0,
|
||||
"endLine": 18,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "a2f744d9dd9b6163be489b540f3c3c39f2760f47",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "68d0cd13_65394952",
|
||||
"filename": "refstack/tests/api/test_profile.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2021-01-22T18:14:52Z",
|
||||
"side": 1,
|
||||
"message": "belongs on line 17 /stdlib group per hacking rules",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 0,
|
||||
"endLine": 23,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "a2f744d9dd9b6163be489b540f3c3c39f2760f47",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue