Update patch set 4
Patch Set 4: Code-Review-1 (3 comments) a few questions and one small editorial change. Patch-set: 4 Reviewer: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
37df84eeb6
commit
6c46ca2b81
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "73cb11fd_b33f4894",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 7160
|
||||
},
|
||||
"writtenOn": "2021-01-06T21:04:36Z",
|
||||
"side": 1,
|
||||
"message": "remove \"in an\"",
|
||||
"range": {
|
||||
"startLine": 9,
|
||||
"startChar": 58,
|
||||
"endLine": 9,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "093d0211ac3cc25e5865e6e2ef84698c46ec2494",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "75088153_d3dfb93f",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 19,
|
||||
"author": {
|
||||
"id": 7160
|
||||
},
|
||||
"writtenOn": "2021-01-06T21:04:36Z",
|
||||
"side": 1,
|
||||
"message": "agree.\n\nBut what happened to nginx service? is that no longer needed?",
|
||||
"range": {
|
||||
"startLine": 15,
|
||||
"startChar": 0,
|
||||
"endLine": 19,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "093d0211ac3cc25e5865e6e2ef84698c46ec2494",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "43a5b6e8_dccabc2e",
|
||||
"filename": "docker/refstack.conf",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 7160
|
||||
},
|
||||
"writtenOn": "2021-01-06T21:04:36Z",
|
||||
"side": 1,
|
||||
"message": "Is IP address always hardwired? or is this need to be modified before deployment or after deployment but before running refstack?",
|
||||
"range": {
|
||||
"startLine": 16,
|
||||
"startChar": 35,
|
||||
"endLine": 16,
|
||||
"endChar": 47
|
||||
},
|
||||
"revId": "093d0211ac3cc25e5865e6e2ef84698c46ec2494",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue