openinfra
/
refstack
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

I'd suggest to do the diversity change in another patch as this one is quite robust already ... btw, the gates should be fixed by this change: 
https://review.opendev.org/c/osf/refstack/+/769986

Patch-set: 6
Reviewer: Gerrit User 22873 <22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 22873 2021-01-08 20:29:34 +00:00 committed by Gerrit Code Review
parent 3e8042412f
commit 8b28fd091a
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
c91ca4e0e039fbe59c4cd2ed26306e0fd3274854
View File

@ -16,6 +16,24 @@
"revId": "c91ca4e0e039fbe59c4cd2ed26306e0fd3274854",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "56c0ae24_ce6eedc1",
"filename": "tox.ini",
"patchSetId": 6
},
"lineNbr": 14,
"author": {
"id": 22873
},
"writtenOn": "2021-01-08T20:29:34Z",
"side": 1,
"message": "Could we do that in another patch? I need to check when tox made the diversity change - if we rename this option we will probably need to bump the version of tox used and etc. This patch is already robust enough, therefore I\u0027d suggest to move the diversity change to another review.",
"parentUuid": "6a70da8a_89c8f3fa",
"revId": "c91ca4e0e039fbe59c4cd2ed26306e0fd3274854",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}