Browse Source

Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
changes/34/772934/meta
Gerrit User 22873 6 months ago
committed by Gerrit Code Review
parent
commit
8de2bc47d8
  1. 18
      94b1fa594f941cb15f9a3d8d6af18b7527f9c366

18
94b1fa594f941cb15f9a3d8d6af18b7527f9c366

@ -16,6 +16,24 @@
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "dae67b7f_0d3ad936",
"filename": "refstack/db/migrations/alembic/utils.py",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 22873
},
"writtenOn": "2021-01-28T22:16:07Z",
"side": 0,
"message": "we don\u0027t have a test for that, you need to try it manually ... I was trying to deploy refstack server on my own machine following this doc\nhttps://opendev.org/osf/refstack/src/branch/master/doc/source/refstack.rst\nwhich is btw outdated - it\u0027s for py2, not py3, that\u0027s another reason I was following the doc - I\u0027m trying to update it.\nWhen you get to the Database sync part, it will be failing at this command:\n$ refstack-manage --config-file /path/to/refstack.conf version\n^^ that\u0027s when that part of the code is executed\n\nthat condition you wrote would solve the problem too (I\u0027ve seen such an example in [1]) , although does it make sense to put it here? this code shouldn\u0027t be ever executed by py2, this db migration is different from [1] - I can imagine (I\u0027m not a web developer) that the response content might be in bytes or doesn\u0027t. But in the case of db migration code, I don\u0027t see such a variability.\n\n[1] https://opendev.org/osf/refstack/src/branch/master/refstack/api/utils.py#L324",
"parentUuid": "1ba23e04_9e49fee3",
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}
Loading…
Cancel
Save