Update patch set 1
Patch Set 1: Code-Review+2 Workflow+1 (1 comment) Sorry to hold this up, thanks for the reproduction instructions and the fix, Martin. LGTM Patch-set: 1 Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2 Label: Workflow=+1
This commit is contained in:
parent
d237977d24
commit
908d0ea7f4
|
@ -52,6 +52,24 @@
|
||||||
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
"unresolved": true
|
"unresolved": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "c20c6e6b_830bd1aa",
|
||||||
|
"filename": "refstack/db/migrations/alembic/utils.py",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 83,
|
||||||
|
"author": {
|
||||||
|
"id": 16643
|
||||||
|
},
|
||||||
|
"writtenOn": "2021-01-29T19:13:33Z",
|
||||||
|
"side": 0,
|
||||||
|
"message": "I see! I was concerned that the prior output was somehow bytes, and the return types may have changed in a newer version of alembic/sqlalchemy; However, it looks like in python2, we were getting a unicode string, and that\u0027s no longer the case with python3 - all strings are the same. There\u0027s some language in the alembic docs that highlights a similar issue, and that gives us a hint: https://alembic.sqlalchemy.org/en/latest/cookbook.html#support-non-ascii-migration-scripts-messages-under-python-2",
|
||||||
|
"parentUuid": "4a5f511d_7da6d471",
|
||||||
|
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": true
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
Loading…
Reference in New Issue