Update patch set 3
Patch Set 3: Code-Review+2 (2 comments) > Patch Set 2: -Code-Review > > > Patch Set 2: Code-Review-1 > > > > (2 comments) > > > > minor nit regarding hacking rules on how we organize imports. > > thanks for noticing, good catch! > Hmm, isn't there a tox/pep/flake config which would make the tox job fail next time when the import are in the wrong order? Thanks for revising this. I think the import order check can be added with flake8-import-order, and setting "import-order-style = pep8" in the flake8 section within tox.ini However, we might find more issues than just the mock library, so we can separate concerns with this change and address that in a separate change. Patch-set: 3 Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2
This commit is contained in:
parent
6c2eaf7533
commit
c428f6f8a8
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3b755b06_622724af",
|
||||
"filename": "refstack/tests/unit/__init__.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2021-01-25T17:39:23Z",
|
||||
"side": 1,
|
||||
"message": "should be in a separate import group, above the third party libs",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 0,
|
||||
"endLine": 18,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "f590029f3c5ba7eafd5d2872d4c31fea8ee9b7e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "86187830_c6daf23e",
|
||||
"filename": "refstack/tests/unit/test_migration.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 20,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2021-01-25T17:39:23Z",
|
||||
"side": 1,
|
||||
"message": "a newline between stdlib and third party libs",
|
||||
"range": {
|
||||
"startLine": 19,
|
||||
"startChar": 25,
|
||||
"endLine": 20,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "f590029f3c5ba7eafd5d2872d4c31fea8ee9b7e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue