From d237977d243acdec33ee5e22e9472bf8418c0e50 Mon Sep 17 00:00:00 2001 From: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 29 Jan 2021 18:34:39 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review+1 (1 comment) Give it +1 for now and will wait for Goutham comment closure. Patch-set: 1 Reviewer: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 --- 94b1fa594f941cb15f9a3d8d6af18b7527f9c366 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/94b1fa594f941cb15f9a3d8d6af18b7527f9c366 b/94b1fa594f941cb15f9a3d8d6af18b7527f9c366 index bfbce3ac..08f1fc07 100644 --- a/94b1fa594f941cb15f9a3d8d6af18b7527f9c366 +++ b/94b1fa594f941cb15f9a3d8d6af18b7527f9c366 @@ -34,6 +34,24 @@ "revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true + }, + { + "key": { + "uuid": "4a5f511d_7da6d471", + "filename": "refstack/db/migrations/alembic/utils.py", + "patchSetId": 1 + }, + "lineNbr": 83, + "author": { + "id": 7160 + }, + "writtenOn": "2021-01-29T18:34:39Z", + "side": 0, + "message": "Goutham, why do you want to keep decoding step? My understanding that it works without these lines for py3. Are you anticipating that for some future version we will need to do some decoding?", + "parentUuid": "dae67b7f_0d3ad936", + "revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true } ] } \ No newline at end of file