openinfra
/
refstack
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Give it +1 for now and will wait for Goutham comment closure.

Patch-set: 1
Reviewer: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 7160 2021-01-29 18:34:39 +00:00 committed by Gerrit Code Review
parent 8de2bc47d8
commit d237977d24
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
94b1fa594f941cb15f9a3d8d6af18b7527f9c366
View File

@ -34,6 +34,24 @@
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4a5f511d_7da6d471",
"filename": "refstack/db/migrations/alembic/utils.py",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 7160
},
"writtenOn": "2021-01-29T18:34:39Z",
"side": 0,
"message": "Goutham, why do you want to keep decoding step? My understanding that it works without these lines for py3. Are you anticipating that for some future version we will need to do some decoding?",
"parentUuid": "dae67b7f_0d3ad936",
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}