Browse Source

Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
changes/34/772934/meta
Gerrit User 16643 6 months ago
committed by Gerrit Code Review
parent
commit
d763a697ba
  1. 21
      94b1fa594f941cb15f9a3d8d6af18b7527f9c366

21
94b1fa594f941cb15f9a3d8d6af18b7527f9c366

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "1ba23e04_9e49fee3",
"filename": "refstack/db/migrations/alembic/utils.py",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 16643
},
"writtenOn": "2021-01-28T21:14:17Z",
"side": 0,
"message": "Hi Martin, where is this failing?\n\nI can\u0027t see where the return types are changing with python versions just by looking at the libraries and methods used here. I wonder if hardening this a bit like:\n\n current_name \u003d (current_name.decode() if isinstance(current_name, bytes)\n else current_name)\n\nwould be better?",
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}
Loading…
Cancel
Save