In the previous fix [1] the value of pubkey.encode() was
forgotten to be assigned which basically makes it a noop
operation. This patch fixes that.

[1] https://review.opendev.org/c/osf/refstack/+/776168

Change-Id: I93a4e5d8afde7e3abfdcf66220c64cda111d4a48

Follow up change for py2->py3 migration.
The pubkey must be encoded in order to avoid 'data must be
bytes-like' error. The key is a type of str which in py2 meant
bytes, however, in py3 it's just string. Therefore the pubkey
must be encoded before it's passed to load_ssh_public_key which
requires bytes-like data.

Change-Id: I943438a59923bd9c4e9dd38058020e49fd2f3d24

Refstack server was still downloading guidelines and
capabilities from the old interop repositoty hosted
on github.com. This patch changes default repo URLs
so that the guidelines are download from the current
interop repo hosted on opendev.org.

Change-Id: Ic05a2a784c8e513e09bc430139011aa73bea062e

This is a follow up on 'py3 only' changes. Previously in py2
current_name variable had unicode type, however in py3 it is
a str type which leads to an Attribute error when the code
is executed by py3 ('str' object has no attribute 'decode').

Now when refstack is py3 only, we don't need to be decoding
current_name variable, the patch removes this conversion.

More about str and unicode and their meaning in py2 and py3:
 * https://portingguide.readthedocs.io/en/latest/strings.html

Change-Id: Ibc76a8797b467d45b05c6e6e61d4bc703a5d701f

The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Change-Id: I70a406c060ba681ddc000788b3fa5ab2bba4d41f

The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.

We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.

Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]

[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328

Change-Id: I6bc5768e9c06f266c71188b867d15c3dde417d44

As we have already dropped python2 support,
usage of six module is redundant.
The patch also edits the classifiers in setup.cfg
which comply with the wallaby cycle goals.

Change-Id: I2b0e4050e489ddfc7cbabe4165d5499ba6788422

tox deprecated its whitelist_externals option in
3.18 release. The patch bumps the min version of tox
to 3.18 and renames the option from whitelist_externals
to allowlist_externals.

Change-Id: I12d4bb75839adf78c17e8e562535fbf0d7e2e816

This repository is hosted on opendev.org's
gitea server, and doesn't get mirrored to
github currently (we may add mirroring in
the future). We can swap a bunch of URLs
that assume the content is on github and
older infra cgit servers with correct URLs.

Meetings have moved from IRC to MeetPad,
fix the corresponding details in the README.

Also use this commit to strip trailing
whitespaces across the repository.

Change-Id: Ica0a7ba08d9c437f94fbc9ab282bd929f01df8ff

A new version of PyJWT==2.0.0 got released a few days back which
changes a few significant things such as return types and option
names, see:
03610f0103/CHANGELOG.md (v200)
This commit edits the code of refstack in order to comply with the newest
changes of PyJWT.

Change-Id: I153384cd39ebadb8ee9eb3d99cd21aa02b8c0673

* Starting in mysql8, we can't expect a db user to be
  created with the GRANT command, we'll need to create
  one explicitly.

* OpenStack has dropped the py2.7 and py3.5 support
  in ussuri cycle. From now on, refstack will test only
  with py3 jobs. Complete discussion & schedule can be
  found in
  - http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
  - https://etherpad.openstack.org/p/drop-python2-support

  Ussuri Communtiy-wide goal:
  https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html

* Replace the "refstack-tox-py36-func-mysql" with
  "refstack-tox-functional" to simplify naming and use the system default
  python3 version for this functional job.

* replace testr unit test runner by stestr. testr runner hasn't been updated
  for ~ 6 years - stestr is its successor

Story: 2003257
Task: 24062
Change-Id: I90ab2eca6366f0b6256f097712efac2ffe08b2c0

Interop repos have been removed from
openstack namespace to osf namespace (Depends-On),
which need update the .gitreview to start using the
new location.

Disable failing jobs to be able to merge this change.

Depends-On: https://review.opendev.org/#/c/734669/
Change-Id: I015e8f1ee0c3bdfe490b4fbf9d67206a178af8a4

At some point ssh-keygen changed its default output format and now
python cryptography can't read the new default. Address this by forcing
the PEM output format which cryptography can read without problems.

Note this is a docs only change to help end users generate keys that
work with refstack after a user reported trouble with this.

Change-Id: I9d1f503817fee69fe22f19a98b506448bda1f888

In bindep we specify we need GCC to compile deps and set tags to compile
and test as appropriate as none of these packages are needed as runtime
dependencies. In requirements.txt we unpin alembic and beaker and add
PyMySQL. Alembic and beaker need to be unpinned to work with modern
python3 and PyMySQL is a python only runtime dep if using MySQL.

This makes building docker images much simpler.

Change-Id: I18a296de190324c545feda3b1b87e0a9424d0f96

This is a small utility script to install nodejs and npm and yarn for
you.

Change-Id: Iebfadb0d7cfa341f95b4dcd025313a1b8f4d3b55

Change-Id: I2ba52622f3a7f0a0b23ea53193751b60f24c45d2

Mailinglists have been updated. Openstack-discuss replaces openstack-dev.

Change-Id: I30311d87eaaa33edf42201f59ef597e21808d4b9

As it was announced [1] global bindep-fallback.txt was removed and now
projects need to have a local bindep.txt to be able to install binary
dependencies for testing.

In test jobs the script tools/test-setup.sh is called which requires
mysql and postgres servers and clients to be installed.

To eliminate 'ERROR: InterpreterNotFound: python3.5' of the zuul job
refstack-tox-py35-func-mysql, simply replace the tox environment
py35-func-mysql to py36-func-mysql with a base python of 3.6 instead of
3.5 and rename the zuul job to contain py36 in the name.

Update the Zuul template to use nodejs6 jobs, this makes the single jobs
obsolete, remove them. Without this change, the gate will use
nodejs4 and fail.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007272.html

Change-Id: I90cb912befb9d09fed330bd8d27a491caffbf7b9

There are many references to review.openstack.org, and while the
redirect should work, we can also go ahead and fix them.

Change-Id: I70c590322ca5c20636ac8f4e0a5233dae4cb832e

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

Tempest has switched from stestr some time ago, so tempest
results are no longer stored under .tempest/.testrepository
but they are stored under .tempest/.stestr instead.

Change-Id: I2f0f47c8989138b361375ba91c1e9cd719ea9a8b

Use openstack-tox-cover template, this runs the cover job
in the check queue only.

Remove jobs and use template instead.

Change-Id: I02c0c5e8b706c1170bd5b782eb624b4429d97053

This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ib27ba59598ed03b7c8ae671bcd067c0e71df3c85
Story: #2002586
Task: #24759

This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I0e29ab2bad85fe535438665260a3535eae75ad12
Story: #2002586
Task: #24759

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ia4fb2dfa84eeac7a56ff2bef90034a38bc2a106b
Story: #2002586
Task: #24759

A quick fix that doesn't really fit well into any of the exisiting
patches in progress

Change-Id: I3c46ed22105c6be974b985ec4c7b2695390f5482

Change-Id: If865b4093796ad99741583d6a10e53578f3f7bd9

mysqld is installed to sbin by default, so if sbin is not in your
path, the tests will fail to set up properly.

Change-Id: I8ca72822ccf19046d1f5634245e972f184f5675a

If not explicitly installed, node packages fail to resolve
properly.

Change-Id: Id18e6004f82b51904ea18eb674cef10490d0e427

New documentation regarding how to install yarn needed double
newlines rather than the current single newlines. As is, it is
rendering as a single line, which is obfuscating eyesore.

Change-Id: I4a3e921342703ea00a4ab622b304c70250006063

* Works with the Docker development image
  * Requires an upgrade to Node 8
  * Using bower-away and yarn for simplicity

Change-Id: I353fb2f01f50f88707341369221d32ac9de513b1

This change will modify a number of things about the way
we manage guideline sources
  - it allows the api to pull guidelines from a list of
    additional guideline sources, as specified in conf
  - changes the object returned by the guidelines api
    from a list to a dictionary of lists pertaining to
    a specific guideline type

Change-Id: Ic42197b32d4c9030a35e613cae8cc64dca794c85

apt update was being run without '-y', which was causing the
update to fail trying to install out of date packages. This
patch adds the `-y` and fixes the Docker build

Change-Id: I1260bb7f0dbcf95378bcda9d449293d02fa9f200

Currently, test results are alternately referred to in the db api
as "test", "results", and "test_result" These varying terminology
choices will become even more obfuscating as we begin using the
new subunit data api, as both "tests" and "results" have very
different semantic meanings within the context of subunit2sql.
This patch will convert all previously used variations to the
more semantically clear phrasing "test_result".

Updating the database to use clearer phrasing may prove to be
worth doing as well, but because I anticipate that that may
end up requiring a bit more discussion.

Change-Id: Ica54b5b8095bd00217aa2ffefab898306c888c3f

Zuul no longer requires the project-name for in-repo configuration.
Omitting it makes forking or renaming projects easier.

Change-Id: Icdeba7a4da08048c3cc5f873e319961e44078c79

This patch disables anonymous test result uploads. It also
fixes a python35 incompatability uncovered by more extensive
testing of signing uploads (bytes can no longer be decoded).
Also updated coverage tests to not include tests in coverage.

Co-Authored-By: megan guiney <meganmguiney@gmail.com>

Change-Id: I3f19f1399eb2948eaf8340b5c4be18b698c7e139

This will allow us to run Py35 tests while testing in the container

Change-Id: Ia95262c37a9eb843b8afdedf6e9adf76a9f5641f

With the update of some linting packages, several style fixes
were needed to conform with the updated style guidelines.

Change-Id: If73036a6d4a3a2f6e93b15d1fa6ed3d253fdc7b1

Implement optional cleanup to support the new PTI jobs
for documentation which won't use tox anymore.

Docs tox environment will still available for developers but
it is no loger used in the gate to construct the documentation.

See http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html

Change-Id: Ib4a380eec3c9f286dc563f2b81c6b27f92467cf3

Change-Id: Ica3dccf138bd1237cc808cd0c8df25372e4188d4