57 lines
3.0 KiB
Plaintext
57 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1ba23e04_9e49fee3",
|
|
"filename": "refstack/db/migrations/alembic/utils.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2021-01-28T21:14:17Z",
|
|
"side": 0,
|
|
"message": "Hi Martin, where is this failing?\n\nI can\u0027t see where the return types are changing with python versions just by looking at the libraries and methods used here. I wonder if hardening this a bit like:\n\n current_name \u003d (current_name.decode() if isinstance(current_name, bytes)\n else current_name)\n\nwould be better?",
|
|
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dae67b7f_0d3ad936",
|
|
"filename": "refstack/db/migrations/alembic/utils.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 22873
|
|
},
|
|
"writtenOn": "2021-01-28T22:16:07Z",
|
|
"side": 0,
|
|
"message": "we don\u0027t have a test for that, you need to try it manually ... I was trying to deploy refstack server on my own machine following this doc\nhttps://opendev.org/osf/refstack/src/branch/master/doc/source/refstack.rst\nwhich is btw outdated - it\u0027s for py2, not py3, that\u0027s another reason I was following the doc - I\u0027m trying to update it.\nWhen you get to the Database sync part, it will be failing at this command:\n$ refstack-manage --config-file /path/to/refstack.conf version\n^^ that\u0027s when that part of the code is executed\n\nthat condition you wrote would solve the problem too (I\u0027ve seen such an example in [1]) , although does it make sense to put it here? this code shouldn\u0027t be ever executed by py2, this db migration is different from [1] - I can imagine (I\u0027m not a web developer) that the response content might be in bytes or doesn\u0027t. But in the case of db migration code, I don\u0027t see such a variability.\n\n[1] https://opendev.org/osf/refstack/src/branch/master/refstack/api/utils.py#L324",
|
|
"parentUuid": "1ba23e04_9e49fee3",
|
|
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "4a5f511d_7da6d471",
|
|
"filename": "refstack/db/migrations/alembic/utils.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 7160
|
|
},
|
|
"writtenOn": "2021-01-29T18:34:39Z",
|
|
"side": 0,
|
|
"message": "Goutham, why do you want to keep decoding step? My understanding that it works without these lines for py3. Are you anticipating that for some future version we will need to do some decoding?",
|
|
"parentUuid": "dae67b7f_0d3ad936",
|
|
"revId": "94b1fa594f941cb15f9a3d8d6af18b7527f9c366",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |