stackforge/cookbook-pacemaker
Code Issues Proposed changes

improve variable names

Browse Source
This commit is contained in:
Adam Spiers
2014-01-24 11:59:27 +00:00
parent fb05d45e57
commit 5dfc1a1571
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
providers/primitive.rb
View File

@@ -148,21 +148,22 @@ end
def modify_params(name, cmds, data_type) def modify_params(name, cmds, data_type)
configure_cmd_prefix = "crm_resource --resource #{name}" configure_cmd_prefix = "crm_resource --resource #{name}"
new_resource.send(data_type).each do |k, v| new_resource.send(data_type).each do |param, new_value|
if @current_resource.send(data_type)[k] == v current_value = @current_resource.send(data_type)[param]
Chef::Log.info("#{name}'s #{k} #{data_type} didn't change") if current_value == new_value
Chef::Log.info("#{name}'s #{param} #{data_type} didn't change")
else else
Chef::Log.info("#{name}'s #{k} #{data_type} changed to #{v}") Chef::Log.info("#{name}'s #{param} #{data_type} changed to #{new_value}")
cmd = configure_cmd_prefix + %' --set-parameter "#{k}" --parameter-value "#{v}"' cmd = configure_cmd_prefix + %' --set-parameter "#{param}" --parameter-value "#{new_value}"'
cmd += " --meta" if data_type == :meta cmd += " --meta" if data_type == :meta
cmds << cmd cmds << cmd
end end
end end
@current_resource.send(data_type).each do |k, v| @current_resource.send(data_type).each do |param, value|
unless new_resource.send(data_type).has_key? k unless new_resource.send(data_type).has_key? param
Chef::Log.info("#{name}'s #{k} #{data_type} was removed") Chef::Log.info("#{name}'s #{param} #{data_type} was removed")
cmd = configure_cmd_prefix + %' --delete-parameter "#{k}"' cmd = configure_cmd_prefix + %' --delete-parameter "#{param}"'
cmd += " --meta" if data_type == :meta cmd += " --meta" if data_type == :meta
cmds << cmd cmds << cmd
end end