stackforge/cookbook-pacemaker
Code Issues Proposed changes

extract provider initialization into let() block

Browse Source
This commit is contained in:
Adam Spiers
2014-01-24 11:22:50 +00:00
parent 1ec358eed0
commit d98c0877e2
1 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
spec/providers/primitive_spec.rb
View File

@@ -24,9 +24,10 @@ describe "Chef::Provider::PacemakerPrimitive" do
@resource.op Hash[ra[:op]] @resource.op Hash[ra[:op]]
end end
let (:provider) { Chef::Provider::PacemakerPrimitive.new(@resource, @run_context) }
describe ":create action" do describe ":create action" do
it "should modify the primitive if it already exists" do it "should modify the primitive if it already exists" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
new_params = Hash[ra[:params]].merge("os_password" => "newpasswd") new_params = Hash[ra[:params]].merge("os_password" => "newpasswd")
new_params.delete("os_tenant_name") new_params.delete("os_tenant_name")
@resource.params new_params @resource.params new_params
@@ -52,8 +53,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
end end
it "should create a primitive if it doesn't already exist" do it "should create a primitive if it doesn't already exist" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
# and later used to see whether to create or modify. # and later used to see whether to create or modify.
expect(provider).to receive(:get_cib_object_definition).and_return("") expect(provider).to receive(:get_cib_object_definition).and_return("")
@@ -74,7 +73,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
it "should barf if the primitive has the wrong agent" do it "should barf if the primitive has the wrong agent" do
existing_agent = "ocf:openstack:something-else" existing_agent = "ocf:openstack:something-else"
config = ra[:config].sub(ra[:agent], existing_agent) config = ra[:config].sub(ra[:agent], existing_agent)
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
# and later used to see whether to create or modify. # and later used to see whether to create or modify.
@@ -92,8 +90,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
shared_examples "action on non-existent resource" do |action, cmd, expected_error| shared_examples "action on non-existent resource" do |action, cmd, expected_error|
it "should not attempt to #{action.to_s} a non-existent resource" do it "should not attempt to #{action.to_s} a non-existent resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).once.and_return("") expect(provider).to receive(:get_cib_object_definition).once.and_return("")
@@ -114,8 +110,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
:delete, "crm configure delete #{ra[:name]}", nil :delete, "crm configure delete #{ra[:name]}", nil
it "should not delete a running resource" do it "should not delete a running resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).once.and_return(ra[:config]) expect(provider).to receive(:get_cib_object_definition).once.and_return(ra[:config])
@@ -129,8 +123,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
end end
it "should delete a non-running resource" do it "should delete a non-running resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).once.and_return(ra[:config]) expect(provider).to receive(:get_cib_object_definition).once.and_return(ra[:config])
@@ -149,8 +141,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
"Cannot start non-existent resource primitive '#{ra[:name]}'" "Cannot start non-existent resource primitive '#{ra[:name]}'"
it "should do nothing to a started resource" do it "should do nothing to a started resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config]) expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config])
@@ -163,8 +153,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
end end
it "should start a stopped resource" do it "should start a stopped resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
config = ra[:config].sub("Started", "Stopped") config = ra[:config].sub("Started", "Stopped")
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).and_return(config) expect(provider).to receive(:get_cib_object_definition).and_return(config)
@@ -185,8 +173,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
"Cannot stop non-existent resource primitive '#{ra[:name]}'" "Cannot stop non-existent resource primitive '#{ra[:name]}'"
it "should do nothing to a stopped resource" do it "should do nothing to a stopped resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config]) expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config])
@@ -199,8 +185,6 @@ describe "Chef::Provider::PacemakerPrimitive" do
end end
it "should stop a started resource" do it "should stop a started resource" do
provider = Chef::Provider::PacemakerPrimitive.new(@resource, @run_context)
# get_cib_object_definition is invoked by load_current_resource # get_cib_object_definition is invoked by load_current_resource
expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config]) expect(provider).to receive(:get_cib_object_definition).and_return(ra[:config])