stackforge/cookbook-pacemaker
Code Issues Proposed changes

Commit Graph

  • 39433937a1 install pacemaker-mgmt package for hb_gui to work Adam Spiers 2014-03-13 17:02:04 +00:00
  • aca5a0f132 Merge pull request #27 from aspiers/hb_gui-fonts Adam Spiers 2014-03-13 09:21:10 +00:00
  • e73306498d hb_gui requires xorg-x11-fonts Adam Spiers 2014-03-12 23:24:28 +00:00
  • 6ddae42c0d Allow a retry when creating a VIP primitive in pacemaker_vip_primitive Vincent Untz 2014-03-11 07:58:28 +01:00
  • 1f3542d5a0 silence warnings during rspec test runs Adam Spiers 2014-03-06 23:29:21 +00:00
  • 391eff06be Add pacemaker_vip_primitive definition helper for cookbooks Vincent Untz 2014-02-27 17:24:44 +01:00
  • 6ea5544a66 Add attributes to choose whether to install graphical UI or not Vincent Untz 2014-02-27 11:06:24 +01:00
  • 17e87c6777 Move RHEL-specific bit out of founder-exclusive code path Vincent Untz 2014-02-27 11:08:49 +01:00
  • 99c7130e61 Install pacemaker packages before corosync Vincent Untz 2014-02-27 11:02:48 +01:00
  • f66268162d Simplify roles a bit Vincent Untz 2014-02-27 11:01:18 +01:00
  • 8215e403df Remove unused bits in pacemaker cookbook Vincent Untz 2014-02-27 10:52:53 +01:00
  • 3576656c33 shared_examples need to include Chef::RSpec::Pacemaker::CIBObject Adam Spiers 2014-02-07 01:32:57 +00:00
  • 162de47f95 fix buggy verification of primitive resource creation Adam Spiers 2014-02-07 01:09:55 +00:00
  • d886f00432 make meta/op/params default to {} Adam Spiers 2014-02-06 21:54:22 +00:00
  • 469950c29b prevent @@subclasses from being emptied Adam Spiers 2014-02-06 21:50:29 +00:00
  • f127600a60 add resource groups Adam Spiers 2014-02-04 17:42:21 +00:00
  • 012c70f6dc remove extraneous else Adam Spiers 2014-02-06 18:58:53 +00:00
  • 66daffffbb extract CIB definition formatting code for reuse Adam Spiers 2014-02-06 18:52:45 +00:00
  • cb0d3adfb0 define TYPE for clone Adam Spiers 2014-02-06 18:47:57 +00:00
  • 6acff71daa merge helpers/cib_object.rb and helpers/common_object_examples.rb Adam Spiers 2014-02-06 18:40:05 +00:00
  • 5df9f7cf95 extract meta attribute tests for reuse Adam Spiers 2014-02-06 18:37:17 +00:00
  • daf3022e96 extract meta attribute handling to Pacemaker::Resource::Meta mixin Adam Spiers 2014-02-06 18:32:56 +00:00
  • ac1f930681 move extract_hash to Pacemaker::Resource Adam Spiers 2014-02-06 18:22:28 +00:00
  • 8607295e05 extract #stop_runnable_resource Adam Spiers 2014-02-06 16:27:48 +00:00
  • 7d071e9966 extract #start_runnable_resource Adam Spiers 2014-02-06 16:27:00 +00:00
  • d5415db590 extract #delete_runnable_resource Adam Spiers 2014-02-06 16:23:50 +00:00
  • 647fe52079 extract #standard_delete_resource Adam Spiers 2014-02-06 16:21:34 +00:00
  • a01427b697 eliminate redundant CIB object instantiation Adam Spiers 2014-02-06 16:14:54 +00:00
  • 14ed45310e add comment explaining standard_cib_object.rb Adam Spiers 2014-02-06 16:01:26 +00:00
  • 8c7ce24e78 rename Chef::RSpec::Pacemaker::Common to ..::CIBObject Adam Spiers 2014-02-06 15:37:54 +00:00
  • a8c9679919 rename Chef::Mixin::PacemakerCommon to Chef::Mixin::Pacemaker::StandardCIBObject Adam Spiers 2014-02-06 13:24:37 +00:00
  • 32b36cfb19 extract tests for runnable resources for reuse Adam Spiers 2014-02-06 10:43:06 +00:00
  • 14b4021a3b use CIB object class description to facilitate code reuse Adam Spiers 2014-02-06 18:09:24 +00:00
  • 6996e0dfeb rename spec/helpers/common.rb to cib_object.rb Adam Spiers 2014-02-06 10:42:30 +00:00
  • 247e5f788b remove broken mixing in of load_current_resource Adam Spiers 2014-02-04 19:08:08 +00:00
  • fe5616cfca stop libraries being required multiple times Adam Spiers 2014-02-05 16:48:19 +00:00
  • a2e9b7f018 make fixture variable name generic to facilitate code reuse Adam Spiers 2014-02-06 10:36:30 +00:00
  • 6f962abf55 Add comment about resource sets Adam Spiers 2014-02-05 17:18:17 +00:00
  • cc8f79a640 Ruby 1.8.7 is missing #singleton_class Adam Spiers 2014-02-04 19:42:53 +00:00
  • e347bdbee2 Pacemaker::CIBObject.from_name requires all subclasses registered Adam Spiers 2014-02-04 19:42:47 +00:00
  • 969bd94ba0 use temporary variables for legibility Adam Spiers 2014-02-04 19:07:21 +00:00
  • ac2b8652cb refactor crm configure load update command Adam Spiers 2014-02-04 18:25:35 +00:00
  • 2550ef2647 refactor shell quoting into #quoted_definition_string Adam Spiers 2014-02-04 18:20:17 +00:00
  • 4f144955ee fix primitive definition strings with fewer parameters Adam Spiers 2014-02-04 18:13:50 +00:00
  • c21a592ab1 extract fixture_definition variable Adam Spiers 2014-02-04 17:38:57 +00:00
  • 9ba8b918ff reuse TYPE variable Adam Spiers 2014-02-04 17:36:22 +00:00
  • 5bc3db1141 add Pacemaker::Constraint::Colocation Adam Spiers 2014-01-30 16:35:53 +00:00
  • abd973937c ditch require_relative which requires Ruby >= 1.9.2 Adam Spiers 2014-02-04 13:37:31 +00:00
  • 0ac14ce0df move shared examples for action on non-existent resource to common.rb Adam Spiers 2014-02-04 13:01:47 +00:00
  • 436bd1ea4e extract test expectations helper code for reuse Adam Spiers 2014-02-04 11:53:53 +00:00
  • 780ea226da use cib_object_class more to make test code more reusable Adam Spiers 2014-02-04 11:52:58 +00:00
  • e282fc2d28 extract standard_create_resource Adam Spiers 2014-02-03 15:36:37 +00:00
  • ba39273800 use generic cib_object variable to make action code more reusable Adam Spiers 2014-02-03 14:34:37 +00:00
  • 67e6dd3d09 use cib_object_class more to make action code more reusable Adam Spiers 2014-02-03 14:24:25 +00:00
  • 34fb97e29d tidy up string handling Adam Spiers 2014-02-03 14:05:09 +00:00
  • c3be9fefb4 extract copy_attrs_to_chef_resource for reuse Adam Spiers 2014-02-03 13:09:02 +00:00
  • 0b0dc4f384 remove trailing whitespace Adam Spiers 2014-02-03 12:55:51 +00:00
  • 18b5233438 ditch obsolete comment Adam Spiers 2014-02-03 12:41:21 +00:00
  • 703c366d8d extract some of load_current_resource for reuse Adam Spiers 2014-01-31 23:20:42 +00:00
  • a518ca0468 extract standard CIB object examples for reuse Adam Spiers 2014-01-31 22:42:09 +00:00
  • e96a3018fb support modification of primitive op values Adam Spiers 2014-01-31 21:52:04 +00:00
  • e7ac5df4d0 add more primitive modification tests Adam Spiers 2014-01-31 21:51:44 +00:00
  • a6ede173df fix parsing of primitive op parameters Adam Spiers 2014-01-31 20:52:08 +00:00
  • 3feb8567c6 test coverage reports Adam Spiers 2014-01-31 18:30:30 +00:00
  • cb7b1b038a wrap long require lines Adam Spiers 2014-01-31 15:55:35 +00:00
  • c9d2617c1f remove trailing space Adam Spiers 2014-01-31 14:36:08 +00:00
  • a711277f16 allow from_definition to be invoked from base class Adam Spiers 2014-01-31 15:47:39 +00:00
  • d5f18b6778 fix clone fixture Adam Spiers 2014-01-31 14:36:37 +00:00
  • eaa8af6840 rename spec/helpers/ to spec/fixtures/ Adam Spiers 2014-01-30 17:24:59 +00:00
  • 38e088e1be extract #copy_attrs_from_chef_resource Adam Spiers 2014-01-30 16:55:39 +00:00
  • 0cea1d6cb1 restructure specs/libraries/ to match layout of libraries/ Adam Spiers 2014-01-30 16:35:47 +00:00
  • 30d7defd33 add Travis CI support Adam Spiers 2014-01-30 15:27:05 +00:00
  • fc32b88216 ensure that crmsh is installed early enough Adam Spiers 2014-01-30 15:17:49 +00:00
  • d4b8b6432d move Pacemaker::CIBObject.from_name test to libraries/primitive_spec Adam Spiers 2014-01-29 14:58:42 +00:00
  • 4df1f5c40f use new #from_name logic to handle sanity checks Adam Spiers 2014-01-29 14:22:22 +00:00
  • 2947139632 tidy up custom exceptions Adam Spiers 2014-01-29 14:21:55 +00:00
  • 7a74431e88 switch to OO classes modelling Pacemaker objects Adam Spiers 2014-01-28 17:58:49 +00:00
  • fd3dcd0f77 avoid unnecessary updates from true vs. "True" values Adam Spiers 2014-01-24 12:04:37 +00:00
  • 59efac0c90 improve logging Adam Spiers 2014-01-24 11:59:48 +00:00
  • 5dfc1a1571 improve variable names Adam Spiers 2014-01-24 11:59:27 +00:00
  • fb05d45e57 improve logging Adam Spiers 2014-01-24 11:46:34 +00:00
  • d98c0877e2 extract provider initialization into let() block Adam Spiers 2014-01-24 11:22:50 +00:00
  • 1ec358eed0 add examples for :start and :stop actions Adam Spiers 2014-01-24 11:21:46 +00:00
  • 4d72a9d6a2 remove unnecessary command directive Adam Spiers 2014-01-24 11:07:08 +00:00
  • ba547aeae4 set resource updated flag Adam Spiers 2014-01-24 11:06:54 +00:00
  • 69776a0f52 use execute rather than shell_out! - easier to test Adam Spiers 2014-01-24 11:06:27 +00:00
  • 02907a3516 explain get_cib_object_definition expectation Adam Spiers 2014-01-24 11:05:57 +00:00
  • 7325d6cb44 make error messages consistent Adam Spiers 2014-01-24 11:04:06 +00:00
  • 73d532a7aa primitive_spec.rb: add delete examples Adam Spiers 2014-01-23 17:36:33 +00:00
  • d53b9ccd9c primitive_spec.rb: make ra available to all examples Adam Spiers 2014-01-23 17:36:12 +00:00
  • 2c25088438 fix missed occurrences during rename to pacemaker_resource_running? Adam Spiers 2014-01-23 17:39:12 +00:00
  • 07c28befab add some debug to load_current_resource Adam Spiers 2014-01-23 17:34:32 +00:00
  • 9908ffe300 reuse results from load_current_resource where possible Adam Spiers 2014-01-23 17:34:22 +00:00
  • 66c7828b16 skip whole delete action if resource exists Adam Spiers 2014-01-23 17:33:06 +00:00
  • 51a297c43d ditch unused temporary variable Adam Spiers 2014-01-23 17:32:24 +00:00
  • 6cef509353 "crm configure show foo" exits 0 with no output if foo doesn't exist Adam Spiers 2014-01-23 16:29:28 +00:00
  • ebf3f7c429 test error raised if the primitive has the wrong agent Adam Spiers 2014-01-23 16:22:30 +00:00
  • 20b151e7ea don't hardcode keystone in test code Adam Spiers 2014-01-23 16:22:09 +00:00
  • 8c6a26da74 allow modification of resource params and meta Adam Spiers 2014-01-23 16:09:09 +00:00
  • 67d34f6f83 try to prevent "Error: can't modify string; temporarily locked" Adam Spiers 2014-01-23 15:54:30 +00:00