fdebd24117
In Pacemaker, target-role defaults to 'Started', but we want to allow consumers of the LWRPs the choice whether their newly created resource gets started or not, and we also want to adhere to the Principle of Least Surprise. Therefore we stick to the intuitive semantics that action :create creates the resource with target-role="Stopped" in order to prevent it from starting immediately, whereas action [:create, :start] creates the resource and then starts it. Since we are honouring :start / :stop actions to determine the target-role value, if target-role is specified via meta, it will just be overridden anyway. So we also deprecate direct use of target-role meta parameter in recipes.
140 lines
5.0 KiB
Ruby
140 lines
5.0 KiB
Ruby
require 'spec_helper'
|
|
|
|
this_dir = File.dirname(__FILE__)
|
|
require File.expand_path('../helpers/runnable_resource', this_dir)
|
|
require File.expand_path('../fixtures/keystone_primitive', this_dir)
|
|
|
|
describe "Chef::Provider::PacemakerPrimitive" do
|
|
# for use inside examples:
|
|
let(:fixture) { Chef::RSpec::Pacemaker::Config::KEYSTONE_PRIMITIVE }
|
|
# for use outside examples (e.g. when invoking shared_examples)
|
|
fixture = Chef::RSpec::Pacemaker::Config::KEYSTONE_PRIMITIVE
|
|
|
|
def lwrp_name
|
|
'primitive'
|
|
end
|
|
|
|
include_context "a Pacemaker LWRP"
|
|
|
|
before(:each) do
|
|
@resource.agent fixture.agent
|
|
@resource.params Hash[fixture.params]
|
|
@resource.meta Hash[fixture.meta]
|
|
@resource.op Hash[fixture.op]
|
|
end
|
|
|
|
def cib_object_class
|
|
Pacemaker::Resource::Primitive
|
|
end
|
|
|
|
describe ":create action" do
|
|
include Chef::RSpec::Pacemaker::CIBObject
|
|
include Chef::RSpec::Mixlib::ShellOut
|
|
|
|
it "should modify the primitive if it has different params" do
|
|
expected_configure_cmd_args = [
|
|
%'--set-parameter "os_password" --parameter-value "newpasswd"',
|
|
%'--delete-parameter "os_tenant_name"',
|
|
].map { |args| "crm_resource --resource #{fixture.name} #{args}" }
|
|
test_modify(expected_configure_cmd_args) do
|
|
new_params = Hash[fixture.params].merge("os_password" => "newpasswd")
|
|
new_params.delete("os_tenant_name")
|
|
@resource.params new_params
|
|
@resource.meta Hash[fixture.meta].merge("target-role" => "Stopped")
|
|
end
|
|
end
|
|
|
|
it "should modify the primitive if it has different meta" do
|
|
expected_configure_cmd_args = [
|
|
%'--set-parameter "is-managed" --parameter-value "false" --meta',
|
|
].map { |args| "crm_resource --resource #{fixture.name} #{args}" }
|
|
test_modify(expected_configure_cmd_args) do
|
|
@resource.params Hash[fixture.params]
|
|
@resource.meta Hash[fixture.meta].merge("is-managed" => "false")
|
|
end
|
|
end
|
|
|
|
it "should modify the primitive if it has different params and meta" do
|
|
expected_configure_cmd_args = [
|
|
%'--set-parameter "os_password" --parameter-value "newpasswd"',
|
|
%'--delete-parameter "os_tenant_name"',
|
|
%'--set-parameter "is-managed" --parameter-value "false" --meta',
|
|
].map { |args| "crm_resource --resource #{fixture.name} #{args}" }
|
|
test_modify(expected_configure_cmd_args) do
|
|
new_params = Hash[fixture.params].merge("os_password" => "newpasswd")
|
|
new_params.delete("os_tenant_name")
|
|
@resource.params new_params
|
|
@resource.meta Hash[fixture.meta].merge("is-managed" => "false")
|
|
end
|
|
end
|
|
|
|
it "should modify the primitive if it has different op values" do
|
|
expected_configure_cmd_args = [
|
|
fixture.reconfigure_command.gsub('60', '120')
|
|
]
|
|
test_modify(expected_configure_cmd_args) do
|
|
new_op = Hash[fixture.op]
|
|
# Ensure we're not modifying our expectation as well as the input
|
|
new_op['monitor'] = new_op['monitor'].dup
|
|
new_op['monitor']['timeout'] = '120'
|
|
@resource.op new_op
|
|
end
|
|
end
|
|
|
|
context "creation from scratch" do
|
|
include_context "stopped resource"
|
|
|
|
it "should create a primitive if it doesn't already exist" do
|
|
# The first time, Mixlib::ShellOut needs to return an empty definition.
|
|
# Then the resource gets created so the second time it needs to return
|
|
# the definition used for creation.
|
|
stub_shellout("", fixture.definition_string)
|
|
|
|
provider.run_action :create
|
|
|
|
expect(@chef_run).to run_execute(stopped_fixture.configure_command)
|
|
expect(@resource).to be_updated
|
|
end
|
|
|
|
it "should barf if crm fails to create the primitive" do
|
|
stub_shellout("", ["crm configure failed", "oh noes", 3])
|
|
|
|
expect { provider.run_action :create }.to \
|
|
raise_error(RuntimeError, "Failed to create #{fixture}")
|
|
|
|
expect(@chef_run).to run_execute(stopped_fixture.configure_command)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
|
|
# This scenario seems rather artificial and unlikely, but it doesn't
|
|
# do any harm to test it.
|
|
it "should barf if crm creates a primitive with empty definition" do
|
|
stub_shellout("", "")
|
|
|
|
expect { provider.run_action :create }.to \
|
|
raise_error(RuntimeError, "Failed to create #{fixture}")
|
|
|
|
expect(@chef_run).to run_execute(stopped_fixture.configure_command)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
end
|
|
|
|
it "should barf if the primitive is already defined with the wrong agent" do
|
|
existing_agent = "ocf:openstack:something-else"
|
|
definition = fixture.definition_string.sub(fixture.agent, existing_agent)
|
|
stub_shellout(definition)
|
|
|
|
expected_error = \
|
|
"Existing #{fixture} has agent '#{existing_agent}' " \
|
|
"but recipe wanted '#{@resource.agent}'"
|
|
expect { provider.run_action :create }.to \
|
|
raise_error(RuntimeError, expected_error)
|
|
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
end
|
|
|
|
it_should_behave_like "a runnable resource", fixture
|
|
|
|
end
|