fdebd24117
In Pacemaker, target-role defaults to 'Started', but we want to allow consumers of the LWRPs the choice whether their newly created resource gets started or not, and we also want to adhere to the Principle of Least Surprise. Therefore we stick to the intuitive semantics that action :create creates the resource with target-role="Stopped" in order to prevent it from starting immediately, whereas action [:create, :start] creates the resource and then starts it. Since we are honouring :start / :stop actions to determine the target-role value, if target-role is specified via meta, it will just be overridden anyway. So we also deprecate direct use of target-role meta parameter in recipes.
129 lines
3.6 KiB
Ruby
129 lines
3.6 KiB
Ruby
# Shared code used to test providers of runnable Chef resources
|
|
# representing Pacemaker CIB objects. For example the provider
|
|
# for primitives is runnable (since primitives can be started
|
|
# and stopped) but constraints cannot.
|
|
|
|
this_dir = File.dirname(__FILE__)
|
|
require File.expand_path('provider', this_dir)
|
|
require File.expand_path('shellout', this_dir)
|
|
|
|
shared_context "stopped resource" do
|
|
def stopped_fixture
|
|
new_fixture = fixture.dup
|
|
new_fixture.meta = fixture.meta.dup
|
|
new_fixture.meta << ['target-role', 'Stopped']
|
|
new_fixture
|
|
end
|
|
end
|
|
|
|
shared_examples "a runnable resource" do |fixture|
|
|
def expect_running(running)
|
|
expect_any_instance_of(cib_object_class) \
|
|
.to receive(:running?) \
|
|
.and_return(running)
|
|
end
|
|
|
|
it_should_behave_like "all Pacemaker LWRPs", fixture
|
|
|
|
include Chef::RSpec::Mixlib::ShellOut
|
|
|
|
describe ":create action" do
|
|
include_context "stopped resource"
|
|
|
|
it "should not start a newly-created resource" do
|
|
stub_shellout("", fixture.definition_string)
|
|
|
|
provider.run_action :create
|
|
|
|
expect(@chef_run).to run_execute(stopped_fixture.configure_command)
|
|
expect(@resource).to be_updated
|
|
end
|
|
end
|
|
|
|
describe ":delete action" do
|
|
it "should not delete a running resource" do
|
|
stub_shellout(fixture.definition_string)
|
|
expect_running(true)
|
|
|
|
expected_error = "Cannot delete running #{fixture}"
|
|
expect { provider.run_action :delete }.to \
|
|
raise_error(RuntimeError, expected_error)
|
|
|
|
cmd = "crm configure delete '#{fixture.name}'"
|
|
expect(@chef_run).not_to run_execute(cmd)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
|
|
it "should delete a non-running resource" do
|
|
stub_shellout(fixture.definition_string)
|
|
expect_running(false)
|
|
|
|
provider.run_action :delete
|
|
|
|
cmd = "crm configure delete '#{fixture.name}'"
|
|
expect(@chef_run).to run_execute(cmd)
|
|
expect(@resource).to be_updated
|
|
end
|
|
end
|
|
|
|
describe ":start action" do
|
|
it_should_behave_like "action on non-existent resource", \
|
|
:start,
|
|
"crm --force resource start #{fixture.name}", \
|
|
"Cannot start non-existent #{fixture}"
|
|
|
|
it "should do nothing to a started resource" do
|
|
stub_shellout(fixture.definition_string)
|
|
expect_running(true)
|
|
|
|
provider.run_action :start
|
|
|
|
cmd = "crm --force resource start #{fixture.name}"
|
|
expect(@chef_run).not_to run_execute(cmd)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
|
|
it "should start a stopped resource" do
|
|
config = fixture.definition_string.sub("Started", "Stopped")
|
|
stub_shellout(config)
|
|
expect_running(false)
|
|
|
|
provider.run_action :start
|
|
|
|
cmd = "crm --force resource start '#{fixture.name}'"
|
|
expect(@chef_run).to run_execute(cmd)
|
|
expect(@resource).to be_updated
|
|
end
|
|
end
|
|
|
|
describe ":stop action" do
|
|
it_should_behave_like "action on non-existent resource", \
|
|
:stop,
|
|
"crm --force resource stop #{fixture.name}", \
|
|
"Cannot stop non-existent #{fixture}"
|
|
|
|
it "should do nothing to a stopped resource" do
|
|
stub_shellout(fixture.definition_string)
|
|
expect_running(false)
|
|
|
|
provider.run_action :stop
|
|
|
|
cmd = "crm --force resource start #{fixture.name}"
|
|
expect(@chef_run).not_to run_execute(cmd)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
|
|
it "should stop a started resource" do
|
|
stub_shellout(fixture.definition_string)
|
|
expect_running(true)
|
|
|
|
provider.run_action :stop
|
|
|
|
cmd = "crm --force resource stop '#{fixture.name}'"
|
|
expect(@chef_run).to run_execute(cmd)
|
|
expect(@resource).to be_updated
|
|
end
|
|
end
|
|
|
|
end
|