stackforge/pecan
Code Issues Proposed changes

Refactor 204 handling.

Browse Source 
Place the HTTP 204 handling in a `finally` at the bottom of the WSGI __call__
to ensure we catch *all* changes to `state.response`.

Change-Id: Id150205f295a3c0ca9c73ad897a41d4790476811
This commit is contained in:
Ryan Petrello
2014-07-11 11:25:22 -04:00
parent 236301f6d7
commit 489afb7819
1 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
pecan/core.py
View File

@@ -566,33 +566,37 @@ class PecanBase(object):
resp.text = result resp.text = result
elif result: elif result:
resp.body = result resp.body = result
elif response.status_int == 200:
if pecan_state['content_type']:
# set the content type
resp.content_type = pecan_state['content_type']
def _handle_empty_response_body(self, state):
# Enforce HTTP 204 for responses which contain no body
if state.response.status_int == 200:
# If the response is a generator... # If the response is a generator...
if isinstance(response.app_iter, types.GeneratorType): if isinstance(state.response.app_iter, types.GeneratorType):
# Split the generator into two so we can peek at one of them # Split the generator into two so we can peek at one of them
# and determine if there is any response body content # and determine if there is any response body content
a, b = tee(response.app_iter) a, b = tee(state.response.app_iter)
try: try:
next(a) next(a)
except StopIteration: except StopIteration:
# If we hit StopIteration, the body is empty # If we hit StopIteration, the body is empty
resp.status = 204 state.response.status = 204
finally: finally:
resp.app_iter = b state.response.app_iter = b
else: else:
text = None text = None
if response.charset: if state.response.charset:
# `response.text` cannot be accessed without a charset # `response.text` cannot be accessed without a charset
# (because we don't know which encoding to use) # (because we don't know which encoding to use)
text = response.text text = state.response.text
if not any((response.body, text)): if not any((state.response.body, text)):
resp.status = 204 state.response.status = 204
if resp.status_int in (204, 304): if state.response.status_int in (204, 304):
resp.content_type = None state.response.content_type = None
elif pecan_state['content_type']:
# set the content type
resp.content_type = pecan_state['content_type']
def __call__(self, environ, start_response): def __call__(self, environ, start_response):
''' '''
@@ -663,6 +667,8 @@ class PecanBase(object):
self.determine_hooks(state.controller), 'after', state self.determine_hooks(state.controller), 'after', state
) )
self._handle_empty_response_body(state)
# get the response # get the response
return state.response(environ, start_response) return state.response(environ, start_response)