stackforge/pecan
Code Issues Proposed changes

Merge "Allow all RFC3986-specified characters in explicit path segments."

Browse Source
This commit is contained in:
Jenkins
2015-07-09 21:15:34 +00:00
committed by Gerrit Code Review
parent f8cdcb7711 3faec0800e
commit cbcc8b3e51
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pecan/routing.py
View File

@@ -42,7 +42,9 @@ def route(*args):
if not isinstance(route, six.string_types): if not isinstance(route, six.string_types):
raise TypeError('%s must be a string' % route) raise TypeError('%s must be a string' % route)
if not re.match('^[0-9a-zA-Z-_$\(\),;:]+$', route): if route in ('.', '..') or not re.match(
'^[0-9a-zA-Z-_$\(\)\.~!,;:*+@=]+$', route
):
raise ValueError( raise ValueError(
'%s must be a valid path segment. Keep in mind ' '%s must be a valid path segment. Keep in mind '
'that path segments should not contain path separators ' 'that path segments should not contain path separators '

7
pecan/tests/test_base.py
View File

@@ -2208,6 +2208,13 @@ class TestExplicitRoute(PecanTestCase):
'path(with-parens)', 'path(with-parens)',
'path;with;semicolons', 'path;with;semicolons',
'path:with:colons', 'path:with:colons',
'v2.0',
'~username',
'somepath!',
'four*four',
'one+two',
'@twitterhandle',
'package=pecan'
): ):
handler = C() handler = C()
route(C, path, handler) route(C, path, handler)