From 19fc83307f1bc664bfa9f9f7794599a3d39c2d28 Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Mon, 23 Sep 2013 16:08:53 -0400 Subject: [PATCH] Fix typo with vncserver_listen and internal_address If vncserver_listen is not set, it should properly fall back to internal_address_real. This fixes an issue with libvirt trying to resolve 'False' as a hostname: getaddrinfo(False,5900): Name or service not known Change-Id: I072aceb4e61c8714b3b0d272c19d10e295fc2eae Signed-off-by: Paul Belanger --- manifests/all.pp | 2 +- spec/classes/openstack_all_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/manifests/all.pp b/manifests/all.pp index 2121e6f..e78f42e 100644 --- a/manifests/all.pp +++ b/manifests/all.pp @@ -248,7 +248,7 @@ class openstack::all ( if $vncserver_listen { $vncserver_listen_real = $vncserver_listen } else { - $vncserver_listen_real = $internal_address + $vncserver_listen_real = $internal_address_real } if $glance_api_servers { $glance_api_servers_real = $glance_api_servers diff --git a/spec/classes/openstack_all_spec.rb b/spec/classes/openstack_all_spec.rb index 98d556e..85dbdda 100644 --- a/spec/classes/openstack_all_spec.rb +++ b/spec/classes/openstack_all_spec.rb @@ -343,7 +343,7 @@ describe 'openstack::all' do it 'should have nova::compute::libvirt configured' do should contain_class('nova::compute::libvirt').with( :libvirt_type => 'kvm', - :vncserver_listen => false, + :vncserver_listen => '10.0.0.1', :migration_support => false ) end