stackforge/puppet-openstack
Code Issues Proposed changes

remove defaults for controller passwords

Browse Source 
Setting default password for everything is setting
people up for accidentally insecure openstack
environments.
This commit is contained in:
Dan Bode
2012-10-24 12:16:17 -07:00
parent da518f627c
commit 5463abbdf1
1 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
manifests/controller.pp
View File

@@ -66,6 +66,23 @@ class openstack::controller (
$public_address, $public_address,
$public_interface, $public_interface,
$private_interface, $private_interface,
$admin_email,
# required password
$admin_password,
$rabbit_password,
$keystone_db_password,
$keystone_admin_token,
$glance_db_password,
$glance_user_password,
$nova_db_password,
$nova_user_password,
$secret_key,
# cinder and quantum password are not required b/c they are
# optional. Not sure what to do about this.
$cinder_user_password = 'cinder_pass',
$cinder_db_password = 'cinder_pass',
$quantum_user_password = 'quantum_pass',
$quantum_db_password = 'quantum_pass',
# Database # Database
$db_host = '127.0.0.1', $db_host = '127.0.0.1',
$db_type = 'mysql', $db_type = 'mysql',
@@ -74,25 +91,17 @@ class openstack::controller (
$mysql_bind_address = '0.0.0.0', $mysql_bind_address = '0.0.0.0',
$allowed_hosts = '%', $allowed_hosts = '%',
# Keystone # Keystone
$admin_email = 'some_user@some_fake_email_address.foo',
$admin_password = 'ChangeMe',
$keystone_db_password = 'keystone_pass',
$keystone_db_user = 'keystone', $keystone_db_user = 'keystone',
$keystone_db_dbname = 'keystone', $keystone_db_dbname = 'keystone',
$keystone_admin_token = 'keystone_admin_token',
$keystone_admin_tenant = 'admin', $keystone_admin_tenant = 'admin',
$region = 'RegionOne', $region = 'RegionOne',
# Glance # Glance
$glance_db_password = 'glance_pass',
$glance_db_user = 'glance', $glance_db_user = 'glance',
$glance_db_dbname = 'glance', $glance_db_dbname = 'glance',
$glance_user_password = 'glance_pass',
$glance_api_servers = undef, $glance_api_servers = undef,
# Nova # Nova
$nova_db_password = 'nova_pass',
$nova_db_user = 'nova', $nova_db_user = 'nova',
$nova_db_dbname = 'nova', $nova_db_dbname = 'nova',
$nova_user_password = 'nova_pass',
$purge_nova_config = true, $purge_nova_config = true,
# Network # Network
$internal_address = $public_address, $internal_address = $public_address,
@@ -107,10 +116,8 @@ class openstack::controller (
$network_config = {}, $network_config = {},
$quantum = true, $quantum = true,
# Rabbit # Rabbit
$rabbit_password = 'rabbit_pw',
$rabbit_user = 'nova', $rabbit_user = 'nova',
# Horizon # Horizon
$secret_key = 'dummy_secret_key',
$cache_server_ip = '127.0.0.1', $cache_server_ip = '127.0.0.1',
$cache_server_port = '11211', $cache_server_port = '11211',
$horizon_app_links = undef, $horizon_app_links = undef,
@@ -121,13 +128,9 @@ class openstack::controller (
$verbose = 'False', $verbose = 'False',
# if the cinder management components should be installed # if the cinder management components should be installed
$cinder = false, $cinder = false,
$cinder_user_password = 'cinder_user_pass',
$cinder_db_password = 'cinder_db_pass',
$cinder_db_user = 'cinder', $cinder_db_user = 'cinder',
$cinder_db_dbname = 'cinder', $cinder_db_dbname = 'cinder',
# #
$quantum_user_password = 'quantum_user_pass',
$quantum_db_password = 'quantum_db_pass',
$quantum_db_user = 'quantum', $quantum_db_user = 'quantum',
$quantum_db_dbname = 'quantum', $quantum_db_dbname = 'quantum',
$enabled = true $enabled = true