Update patch set 9

Patch Set 9: Code-Review-1

(9 comments)

Patch-set: 9
Reviewer: Gerrit User 10475 <10475@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

37846c09139779dca4538b635d1952ffca597241

@@ -0,0 +1,157 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1a930d6b_c2b8efe7",
+        "filename": "rallyclient/_i18n.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "# Copyright 2015 Mirantis Inc.",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_82a507b7",
+        "filename": "rallyclient/_i18n.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "Why does this module name started with underscore?",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_0247571e",
+        "filename": "rallyclient/exc.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "2015",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_220453bf",
+        "filename": "rallyclient/exc.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "Let\u0027s rename this module to `exceptions.py\u0027 to conform rally and OpenStack clients convention",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_8293474e",
+        "filename": "rallyclient/shell.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "Maybe expand rally notation for double quotes to this project as well?",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_053da1bb",
+        "filename": "rallyclient/shell.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 109,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "Do this change explicitly:\n\n Way 1:\n   parser \u003d submodule.enhance_parser(parser, subparsers, self.subcommands)\n\n  Way 2 (looks better for me):\n   # use a subclass of argparse.ArgumentParser,\n   # with extra method `enhance\u0027:\n   parser.enhance(subparsers, self.subcommands)",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_c210efaa",
+        "filename": "rallyclient/utils.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 41,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": ":param cmd_mapper: ...",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_02d757c0",
+        "filename": "rallyclient/utils.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "`help\u0027 is built-in, so its shadowing is bad style\n(even if we will not use this built-in within the scope)\n\nhttp://docs.openstack.org/developer/hacking/",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a930d6b_a245a371",
+        "filename": "rallyclient/v1/shell.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 10475
+      },
+      "writtenOn": "2015-01-22T15:32:53Z",
+      "side": 1,
+      "message": "I think we need return value here since modifying objects implicitly is a way to confusing code",
+      "revId": "37846c09139779dca4538b635d1952ffca597241",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}