stackforge/rubick
Code Issues Proposed changes

Updated schema generator: Do not mark params as new if they were already in database

Browse Source
This commit is contained in:
Maxim Kulkin
2013-11-12 18:13:39 +04:00
parent 60e8859242
commit b571cfdc18
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rubick/schemas/generator.py
View File

@@ -99,7 +99,6 @@ def generate_project_schema(project):
if not prev_param: if not prev_param:
logger.debug('Parameter %s does not exist yet, adding it as new' % param['name']) logger.debug('Parameter %s does not exist yet, adding it as new' % param['name'])
param['comment'] = 'New param'
added.append(param) added.append(param)
else: else:
seen.add(param['name']) seen.add(param['name'])
@@ -176,6 +175,8 @@ def generate_project_schema(project):
for param in added: for param in added:
old_param = old_schema_parameters.get(param['name'], None) old_param = old_schema_parameters.get(param['name'], None)
if not old_param: if not old_param:
if 'comment' not in param:
param['comment'] = 'New param'
continue continue
extra_data = [(k, v) for k, v in old_param.items() extra_data = [(k, v) for k, v in old_param.items()
@@ -207,6 +208,10 @@ def generate_project_schema(project):
logger.debug('Replacing schema record %s' % repr(new_schema_record)) logger.debug('Replacing schema record %s' % repr(new_schema_record))
schema_records[old_schema_record_idx] = new_schema_record schema_records[old_schema_record_idx] = new_schema_record
else: else:
for param in added:
if 'comment' not in param:
param['comment'] = 'New param'
logger.debug('Appending schema record %s' % repr(new_schema_record)) logger.debug('Appending schema record %s' % repr(new_schema_record))
schema_records.append(new_schema_record) schema_records.append(new_schema_record)