stackforge/satori
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4: I would prefer that you didn't merge this

(5 inline comments)



Patch-set: 4
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 5
2014-03-24 21:56:10 +00:00
committed by Gerrit Code Review
parent 69e24518bb
commit 1c4947e52e
1 changed files with 89 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
149bbfbd83a1abb26133ab0fbdc28dd140135d40 Normal file
View File

@@ -0,0 +1,89 @@
{
"comments": [
{
"key": {
"uuid": "AAAAWH/+tps\u003d",
"filename": "satori/bash.py",
"patchSetId": 4
},
"lineNbr": 85,
"author": {
"id": 5
},
"writtenOn": "2014-03-24T21:56:10Z",
"side": 1,
"message": "Copy/paste error: Windows not OSX.",
"revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH/+tt0\u003d",
"filename": "satori/errors.py",
"patchSetId": 4
},
"lineNbr": 26,
"author": {
"id": 5
},
"writtenOn": "2014-03-24T21:56:10Z",
"side": 1,
"message": "Typo: platform",
"revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH/+tto\u003d",
"filename": "satori/ssh.py",
"patchSetId": 4
},
"lineNbr": 52,
"author": {
"id": 5
},
"writtenOn": "2014-03-24T21:56:10Z",
"side": 1,
"message": "If you could read the source of the code using inspect, then we know we\u0027re always using tested code instead of a hard-coded string.",
"revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH/+tsg\u003d",
"filename": "satori/tests/test_bash.py",
"patchSetId": 4
},
"lineNbr": 54,
"author": {
"id": 5
},
"writtenOn": "2014-03-24T21:56:10Z",
"side": 1,
"message": "Use of a extra blank line at start of function is not consistent in this module (and probably unnecessary).",
"revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH/+trU\u003d",
"filename": "satori/tests/test_bash.py",
"patchSetId": 4
},
"lineNbr": 127,
"author": {
"id": 5
},
"writtenOn": "2014-03-24T21:56:10Z",
"side": 1,
"message": "Is 203.0.113.1 a real IP? If so, do we risk hitting it?\n\nMaybe use a loopback or invalid IP? Or a test IP from rfc5735.",
"revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}