From 1c4947e52e441403f7a7b2279561b901afa214e1 Mon Sep 17 00:00:00 2001
From: Gerrit User 5 <5@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 24 Mar 2014 21:56:10 +0000
Subject: [PATCH] Update patch set 4

Patch Set 4: I would prefer that you didn't merge this

(5 inline comments)



Patch-set: 4
Label: Code-Review=-1
Label: Workflow=0
---
 149bbfbd83a1abb26133ab0fbdc28dd140135d40 | 89 ++++++++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 149bbfbd83a1abb26133ab0fbdc28dd140135d40

diff --git a/149bbfbd83a1abb26133ab0fbdc28dd140135d40 b/149bbfbd83a1abb26133ab0fbdc28dd140135d40
new file mode 100644
index 0000000..47ec564
--- /dev/null
+++ b/149bbfbd83a1abb26133ab0fbdc28dd140135d40
@@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "AAAAWH/+tps\u003d",
+        "filename": "satori/bash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 85,
+      "author": {
+        "id": 5
+      },
+      "writtenOn": "2014-03-24T21:56:10Z",
+      "side": 1,
+      "message": "Copy/paste error: Windows not OSX.",
+      "revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAAWH/+tt0\u003d",
+        "filename": "satori/errors.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 5
+      },
+      "writtenOn": "2014-03-24T21:56:10Z",
+      "side": 1,
+      "message": "Typo: platform",
+      "revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAAWH/+tto\u003d",
+        "filename": "satori/ssh.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 52,
+      "author": {
+        "id": 5
+      },
+      "writtenOn": "2014-03-24T21:56:10Z",
+      "side": 1,
+      "message": "If you could read the source of the code using inspect, then we know we\u0027re always using tested code instead of a hard-coded string.",
+      "revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAAWH/+tsg\u003d",
+        "filename": "satori/tests/test_bash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 54,
+      "author": {
+        "id": 5
+      },
+      "writtenOn": "2014-03-24T21:56:10Z",
+      "side": 1,
+      "message": "Use of a extra blank line at start of function is not consistent in this module (and probably unnecessary).",
+      "revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAAWH/+trU\u003d",
+        "filename": "satori/tests/test_bash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 127,
+      "author": {
+        "id": 5
+      },
+      "writtenOn": "2014-03-24T21:56:10Z",
+      "side": 1,
+      "message": "Is 203.0.113.1 a real IP? If so, do we risk hitting it?\n\nMaybe use a loopback or invalid IP? Or a test IP from rfc5735.",
+      "revId": "149bbfbd83a1abb26133ab0fbdc28dd140135d40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}
\ No newline at end of file