Update app Zuul Check Jobs.

Modify code to conform to flake8 and pylint.

Jobs are now flake8, pylint, py39 and metadata.

Test Plan
PASS - All zuul jobs pass as expected.

Story: 2010929
Task: 49253

Change-Id: I1239b1c2a952d822bf5ba7348acc2ff1ce80dd97
Signed-off-by: Reed, Joshua <Joshua.Reed@windriver.com>

.gitignore

@@ -0,0 +1,2 @@
+.tox
+venv/

.zuul.yaml

@@ -7,6 +7,7 @@
         - k8sapp-kubernetes-power-manager-tox-flake8
         - k8sapp-kubernetes-power-manager-tox-pylint
         - k8sapp-kubernetes-power-manager-tox-bandit
+        - k8sapp-kubernetes-power-manager-tox-metadata
     gate:
       jobs:
         - openstack-tox-linters
@@ -14,6 +15,7 @@
         - k8sapp-kubernetes-power-manager-tox-flake8
         - k8sapp-kubernetes-power-manager-tox-pylint
         - k8sapp-kubernetes-power-manager-tox-bandit
+        - k8sapp-kubernetes-power-manager-tox-metadata
     post:
       jobs:
         - stx-app-kubernetes-power-manager-upload-git-mirror
@@ -49,6 +51,25 @@
         tox_envlist: flake8
         tox_extra_args: -c python3-k8sapp-kubernetes-power-manager/k8sapp_kubernetes_power_manager/tox.ini
 
+- job:
+    name: k8sapp-kubernetes-power-manager-tox-metadata
+    parent: tox
+    description: |
+        Run metadata test for kubernetes-power-manager
+    nodeset: debian-bullseye
+    required-projects:
+      - starlingx/config
+      - starlingx/fault
+      - starlingx/update
+      - starlingx/utilities
+      - starlingx/root
+    files:
+      - python3-k8sapp-kubernetes-power-manager/*
+    vars:
+        tox_envlist: metadata
+        tox_extra_args: -c python3-k8sapp-kubernetes-power-manager/k8sapp_kubernetes_power_manager/tox.ini
+        tox_constraints_file: '{{ ansible_user_dir }}/src/opendev.org/starlingx/root/build-tools/requirements/debian/upper-constraints.txt'
+
 - job:
     name: k8sapp-kubernetes-power-manager-tox-pylint
     parent: tox

python3-k8sapp-kubernetes-power-manager/k8sapp_kubernetes_power_manager/tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = flake8,py39,pylint,bandit
+envlist = flake8,py39,pylint,bandit,metadata
 minversion = 1.6
 skipsdist = True
 
@@ -14,6 +14,7 @@ basepython = python3.9
 
 allowlist_externals = bash
                       find
+                      echo
 
 install_command = pip install -v -v -v  \
     -c{toxinidir}/upper-constraints.txt \
@@ -50,7 +51,7 @@ deps = -r{toxinidir}/requirements.txt
 # H404 multi line docstring should start without a leading new line
 # H405 multi line docstring summary not separated with an empty line
 ignore = H403,H404,H405,W503,W504
-# Ignoring 
+# Ignoring
 per-file-ignores =
     k8sapp_kubernetes_power_manager/common/constants.py: E501
 exclude = build,dist,tools,.eggs
@@ -101,3 +102,11 @@ commands =
 deps = pip_missing_reqs
        -rrequirements.txt
 commands=pip-missing-reqs -d --ignore-file=/k8sapp_kubernetes_power_manager/tests k8sapp_kubernetes_power_manager
+
+[testenv:metadata]
+install_command = pip install -v -v -v \
+    -c{env:UPPER_CONSTRAINTS_FILE:https://opendev.org/starlingx/root/raw/branch/master/build-tools/requirements/debian/upper-constraints.txt} \
+    {opts} {packages}
+# Pass top level app folder to 'sysinv-app tox' command.
+commands =
+  bash -c "echo $(dirname $(dirname $(pwd))) | xargs -n 1 sysinv-app tox"

stx-kubernetes-power-manager-helm/debian/deb_folder/rules

@@ -26,9 +26,9 @@ override_dh_auto_build:
 	mkdir -p $(STAGING)/charts
 	cp helm-charts/*.tgz $(STAGING)/charts
 	# Populate metadata
-	sed -i 's/@APP_NAME@/$(APP_NAME)/g' $(STAGING)/metadata.yaml
-	sed -i 's/@APP_VERSION@/$(APP_VERSION)/g' $(STAGING)/metadata.yaml
-	sed -i 's/@HELM_REPO@/$(HELM_REPO)/g' $(STAGING)/metadata.yaml
+	sed -i 's/APP_REPLACE_NAME/$(APP_NAME)/g' $(STAGING)/metadata.yaml
+	sed -i 's/APP_REPLACE_VERSION/$(APP_VERSION)/g' $(STAGING)/metadata.yaml
+	sed -i 's/HELM_REPLACE_REPO/$(HELM_REPO)/g' $(STAGING)/metadata.yaml
 	# Copy the plugins: installed in the buildroot
 	mkdir -p $(STAGING)/plugins
 	cp /plugins/*.whl $(STAGING)/plugins

stx-kubernetes-power-manager-helm/stx-kubernetes-power-manager-helm/files/metadata.yaml

@@ -3,9 +3,9 @@
 # SPDX-License-Identifier: Apache-2.0
 #
 ---
-app_name: @APP_NAME@
-app_version: @APP_VERSION@
-helm_repo: @HELM_REPO@
+app_name: APP_REPLACE_NAME
+app_version: APP_REPLACE_VERSION
+helm_repo: HELM_REPLACE_REPO
 
 maintain_user_overrides: true
 

tox.ini

@@ -51,6 +51,11 @@ basepython = python3
 description = Dummy environment to allow pylint to be run in subdir tox
 
 
+[testenv:metadata]
+basepython = python3
+description = Dummy environment to allow sysinv-app to be run in subdir tox
+
+
 [testenv:bandit]
 basepython = python3
 description = Dummy environment to allow bandit to be run in subdir tox