starlingx
/
app-power-metrics
Code Issues Proposed changes

cadvisor docker image: don't ignore build errors 

A recent Jenkins build failed because the custom build script for the
cadvisor image falsely reported success, which prevented the master
build script from retrying the build of this project.

Solution: exit with non-zero if "docker build" fails

TESTS
======================
- Build image normally
- Force build.sh to return non-zero and make sure the retry logic kicks
  in

Closes-Bug: 2034733
Change-Id: I12adbf41a8e64e1c8cec5cfde23fea1c454538f2
Signed-off-by: Davlet Panech <davlet.panech@windriver.com>
This commit is contained in:
Davlet Panech 2023-09-07 16:09:43 -04:00
parent c1633607e5
commit 17ae181d29
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
stx-power-metrics-images/debian/build.sh
View File

@ -22,7 +22,7 @@ build_cadvisor_image() {
export CADVISOR_IMAGE=$1
echo "cadvisor_image: ${CADVISOR_IMAGE}"
pwd
docker build -t "${CADVISOR_IMAGE}" -f deploy/Dockerfile .
docker build -t "${CADVISOR_IMAGE}" -f deploy/Dockerfile . || exit 1
echo "cadvisor image build done"
return 0
}
@ -31,7 +31,7 @@ build_telegraf_image() {
export TELEGRAF_IMAGE=$1
echo "telegraf_image: ${TELEGRAF_IMAGE}"
pwd
docker build -t "${TELEGRAF_IMAGE}" -f Dockerfile .
docker build -t "${TELEGRAF_IMAGE}" -f Dockerfile . || exit 1
echo "telegraf image build done"
return 0
}