starlingx
/
config
Code Issues Proposed changes

Configuration out-of-date alarms on storage nodes since fresh install 

After fresh install of a Standard configuration with dedicated storage
nodes, the storage node configuration out-of-date alarms are not
cleared. This regression is caused by commit
https://review.opendev.org/#/c/673336/. In check_unlock_storage()
function a call to restore_ceph_config() was replaced by
update_ceph_osd_config() when osdmap is empty. This will generate a
config uuid and invoke config_apply_runtime_manifest before the
.initial_config_complete flag file is created on the storage node.
In this case sysinv-agent won't send response to sysinv-conductor to
clear the configuration out-of-date alarm. The solution is to remove
the code that calls update_ceph_osd_config() in check_unlock_storage()
because ceph config is restored and osds are created automatically
when storage node is unlocked.

Following tests are performed:
  1. Install a storage lab and verify that ceph is running ok without
     storage node configuration out-of-date alarm
  2. Backup and restore a standard storage configuration

Change-Id: If05adc5d30f7ea73cc5e630b4508be0351e4f6e4
Closes-Bug: 1838652
Signed-off-by: Wei Zhou <wei.zhou@windriver.com>
This commit is contained in:
Wei Zhou 2019-08-13 14:04:45 -04:00
parent 9d384d2ba6
commit 1ab1aba4b0
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sysinv/sysinv/sysinv/sysinv/api/controllers/v1/host.py
View File

@ -5402,22 +5402,6 @@ class HostController(rest.RestController):
"enabled.") %
(num_monitors, required_monitors))
try:
# If osdmap is empty which is the restore case, then create osds.
osd_stats = ceph_helper.get_osd_stats()
if int(osd_stats['num_osds']) == 0:
i_host = pecan.request.dbapi.ihost_get(ihost['uuid'])
runtime_manifests = True
for stor in istors:
pecan.request.rpcapi.update_ceph_osd_config(
pecan.request.context,
i_host,
stor.uuid,
runtime_manifests)
except Exception:
raise wsme.exc.ClientSideError(
_("Restore Ceph config failed. Retry unlocking storage node."))
@staticmethod
def check_updates_while_unlocked(hostupdate, delta):
"""Check semantics host-update of an unlocked host."""