starlingx
/
config
Code Issues Proposed changes

Fix out-of-date alarm wrongful removal 

When updating docker service parameters by either adding or
deleting them, a "Configuration is out-of-date" alarm will
automatically appear for both active and standby nodes.
The alarms should only be cleared by a manual lock/unlock
of each node.
The fix addresses the scenario where a configuration update
that triggers a runtime manifest clears the existing out-of-date
alarm (e.g.: system certificate-install -m ssl_ca <cert>).
The issue is reproduced no matter what configuration update with
runtime manifest is used or if the existing alarm was due to a
“service-parameter-add” or a “service-parameter-delete” command.

Closes-Bug: 1878018

Signed-off-by: Carmen Rata <carmen.rata@windriver.com>
Change-Id: I1e545327ae394385c995aee885590779432c60b0
This commit is contained in:
Carmen Rata 2021-02-08 10:35:26 -05:00
parent 0e39d3aca4
commit 500d4e250c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sysinv/sysinv/sysinv/sysinv/conductor/manager.py
View File

@ -8114,6 +8114,7 @@ class ConductorManager(service.PeriodicService):
LOG.info("Updating parameters configuration for service: %s" % service)
config_uuid = None
# On service parameter add just update the host profile
# for personalities pertinent to that service
if service == constants.SERVICE_TYPE_HTTP:
@ -8126,6 +8127,10 @@ class ConductorManager(service.PeriodicService):
pass
elif service == constants.SERVICE_TYPE_PTP:
self._update_ptp_host_configs(context, do_apply=do_apply)
elif service == constants.SERVICE_TYPE_DOCKER:
config_uuid = self._config_update_hosts(context,
[constants.CONTROLLER],
reboot=True)
else:
# All other services
personalities = [constants.CONTROLLER]