starlingx
/
config
Code Issues Proposed changes

Pylint: Enable Undefined Variable Checking 

Pylint currently ignores the following error:
E0602: undefined-variable
Enable it to prevent errors

Story: 2004515
Task: 28687
Change-Id: Ic88ced09d9a9cade6f28d4dcc06d553132ed7f5e
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
This commit is contained in:
Eric Barrett 2019-07-25 11:10:48 -04:00
parent 2c0ee8f207
commit b543132695
4 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sysinv/sysinv/sysinv/pylint.rc
View File

@ -72,7 +72,6 @@ load-plugins=
# E0203: access-member-before-definition
# E0213: no-self-argument
# E0401: import-error
# E0602: undefined-variable
# E0604: invalid-all-object
# E0611: no-name-in-module
# E0633: unpacking-non-sequence
@ -88,7 +87,7 @@ disable=C, R, fixme, W0101, W0102, W0105, W0106, W0107, W0108, W0110, W0120, W01
W0201, W0211, W0212, W0221, W0223, W0231, W0235, W0311, W0402, W0403, W0404,
W0603, W0612, W0613, W0621, W0622, W0631, W0632, W0701, W0703,
W1113, W1201, W1401, W1505,
E0202, E0203, E0213, E0401, E0602, E0604, E0611, E0633, E0701,
E0202, E0203, E0213, E0401, E0604, E0611, E0633, E0701,
E1101, E1102, E1120, E1121, E1124, E1136, E1205
[REPORTS]

12
sysinv/sysinv/sysinv/sysinv/api/controllers/v1/interface_network.py
View File

@ -20,24 +20,24 @@
#
import os
import pecan
import uuid
import wsme
import pecan
import wsmeext.pecan as wsme_pecan
from oslo_log import log
from pecan import rest
from wsme import types as wtypes
import wsmeext.pecan as wsme_pecan
from sysinv import objects
from sysinv.api.controllers.v1 import address_pool
from sysinv.api.controllers.v1 import base
from sysinv.api.controllers.v1 import collection
from sysinv.api.controllers.v1 import types
from sysinv.api.controllers.v1 import utils
from sysinv.common import utils as cutils
from sysinv.common import constants
from sysinv.common import exception
from sysinv import objects
from oslo_log import log
from sysinv.common import utils as cutils
from sysinv.openstack.common.gettextutils import _
LOG = log.getLogger(__name__)

1
sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py
View File

@ -39,6 +39,7 @@ from sysinv.helm import common
from sysinv.helm import helm
from sysinv.helm import manifest
from sysinv.helm import utils as helm_utils
from sysinv.openstack.common.gettextutils import _
# Log and config

18
sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/api.py
View File

@ -30,29 +30,27 @@ from oslo_db import exception as db_exc
from oslo_db.sqlalchemy import enginefacade
from oslo_db.sqlalchemy import utils as db_utils
from sqlalchemy import or_
from sqlalchemy import inspect
from sqlalchemy import or_
from sqlalchemy.orm.exc import DetachedInstanceError
from sqlalchemy.orm.exc import NoResultFound
from sqlalchemy.orm.exc import MultipleResultsFound
from sqlalchemy.orm import with_polymorphic
from sqlalchemy.orm import contains_eager
from sqlalchemy.orm import joinedload
from sqlalchemy.orm import subqueryload
from sqlalchemy.orm import contains_eager
from sqlalchemy.orm import with_polymorphic
from sqlalchemy.orm.exc import DetachedInstanceError
from sqlalchemy.orm.exc import MultipleResultsFound
from sqlalchemy.orm.exc import NoResultFound
from sysinv import objects
from sysinv.common import constants
from sysinv.common import exception
from sysinv.common import utils
from sysinv.db import api
from sysinv.db.sqlalchemy import models
from sysinv import objects
from sysinv.openstack.common import log
from sysinv.openstack.common import uuidutils
from sysinv.openstack.common.gettextutils import _
CONF = cfg.CONF
CONF.import_opt('connection',