From 84fa7b6f7449d7d7752e377cd9483f465d8a281c Mon Sep 17 00:00:00 2001 From: Jia Hu Date: Fri, 26 Nov 2021 15:01:33 -0500 Subject: [PATCH] Cleanup pylint error: attribute_defined_outside_init un-suppress the pylint error check for attribute_defined_outside_init, and update the code to fix that error Test Plan: PASS: tox -e cover PASS: system host-show controller-0 Story: 2008943 Task: 44051 Signed-off-by: Jia Hu Change-Id: I653c3f450eec96b84fa0e661350d308d4d2fdac6 --- sysinv/cgts-client/cgts-client/cgtsclient/common/http.py | 2 ++ sysinv/cgts-client/cgts-client/cgtsclient/shell.py | 4 ++++ sysinv/cgts-client/cgts-client/pylint.rc | 3 +-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/sysinv/cgts-client/cgts-client/cgtsclient/common/http.py b/sysinv/cgts-client/cgts-client/cgtsclient/common/http.py index 7ec5e9ca1..9541b0ebe 100644 --- a/sysinv/cgts-client/cgts-client/cgtsclient/common/http.py +++ b/sysinv/cgts-client/cgts-client/cgtsclient/common/http.py @@ -143,6 +143,8 @@ class HTTPClient(httplib2.Http): # httplib2 overrides self.disable_ssl_certificate_validation = insecure + self.service_catalog = None + ################# # REQUEST ################# diff --git a/sysinv/cgts-client/cgts-client/cgtsclient/shell.py b/sysinv/cgts-client/cgts-client/cgtsclient/shell.py index 5687bcf4a..7e50e34c6 100644 --- a/sysinv/cgts-client/cgts-client/cgtsclient/shell.py +++ b/sysinv/cgts-client/cgts-client/cgtsclient/shell.py @@ -34,6 +34,10 @@ import os class CgtsShell(object): + def __init__(self): + self.subcommands = None + self.parser = None + def get_base_parser(self): parser = argparse.ArgumentParser( prog='system', diff --git a/sysinv/cgts-client/cgts-client/pylint.rc b/sysinv/cgts-client/cgts-client/pylint.rc index 1840a34a8..80d448672 100755 --- a/sysinv/cgts-client/cgts-client/pylint.rc +++ b/sysinv/cgts-client/cgts-client/pylint.rc @@ -118,7 +118,6 @@ enable=E1603,E1609,E1610,E1602,E1606,E1608,E1607,E1605,E1604,E1601,E1611,W1652, # W0110: deprecated-lambda # W0120: useless-else-on-loop # W0123: eval-used -# W0201: attribute-defined-outside-init # W0212: protected-access # W0231: super-init-not-called # W0235: useless-super-delegation @@ -134,7 +133,7 @@ enable=E1603,E1609,E1610,E1602,E1606,E1608,E1607,E1605,E1604,E1601,E1611,W1652, # W1401: anomalous-backslash-in-string # W1618: no-absolute-import disable=C, R, fixme, W0105, W0108, W0110, W0120, W0123, - W0201, W0212, W0231, W0235, W0402, W0403, W0603, W0611, + W0212, W0231, W0235, W0402, W0403, W0603, W0611, W0612, W0613, W0622, W0631, W0703, W1401, W1618