starlingx
/
config
Code Issues Proposed changes

Fix missing runtime apply parameter 

The parameter config_out_of_date_timeout was removed by
commit [1], however a reference to it remained in the code,
introduced by commit [2].

This commit fixes the reference, now declared as a constant
on sysinv/common/constants.py

[1] https://review.opendev.org/c/starlingx/config/+/894544
[2] https://review.opendev.org/c/starlingx/config/+/896164

Test Plan
PASS: force a scenario where an amount of runtime configurations
      are enqueued/deferred, verify no errors on sysinv.log and
      that the message "_ready_to_apply_runtime_config: wait %s secs"
      is shown on the log, indicating that the previous point of
      failure is not failing anymore.

Closes-bug: 2045704

Change-Id: I96d6cbe5087936790a0854a51a464798a87786ef
Signed-off-by: Heitor Matsui <heitorvieira.matsui@windriver.com>
This commit is contained in:
Heitor Matsui 2023-12-05 18:27:59 -03:00
parent aff99f4245
commit dade970c8a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sysinv/sysinv/sysinv/sysinv/conductor/manager.py
View File

@ -6803,7 +6803,7 @@ class ConductorManager(service.PeriodicService):
# event such as lost RPC route update message from agent.
if timestamp:
delta = (datetime.utcnow() - timestamp).total_seconds()
if delta < CONF.conductor.config_out_of_date_timeout / 2:
if delta < constants.RUNTIME_CONFIG_APPLY_TIMEOUT_IN_SECS / 2:
LOG.info("_ready_to_apply_runtime_config: wait %s secs" %
delta)
return False