starlingx/config
Code Issues Proposed changes

Resolving unpacking-non-sequence error

Browse Source 
Pylint error dealt with by per line suppression,
error caused no staticmethod that breaks.

Story: 2007082
Task: 37996

Signed-off-by: Lu Yao Chen <luyao.chen@windriver.com>
Change-Id: I8d56ba47ee58edb070e99c5240afac1fd7942d7a
This commit is contained in:
Lu Yao Chen 2020-12-16 14:43:40 -05:00 committed by Al Bailey
parent 7312b1bf1d
commit e7c99304ce
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sysinv/sysinv/sysinv/pylint.rc
View File

@ -83,14 +83,13 @@ extension-pkg-whitelist=lxml.etree,greenlet
# W1505: deprecated-method
# W1509: subprocess-popen-preexec-fn
# All these errors should be fixed:
# E0633: unpacking-non-sequence
# E1101: no-member
# E1111: assignment-from-no-return
disable=C, R, fixme, W0101, W0105, W0106, W0107, W0108, W0110, W0123, W0150,
W0201, W0211, W0212, W0221, W0223, W0231, W0235, W0311, W0402, W0403,
W0404, W0603, W0612, W0613, W0621, W0622, W0631, W0632, W0701, W0703,
W0706, W1113, W1201, W1401, W1505, W1509,
E0633, E1101, E1111
E1101, E1111
[REPORTS]
# Set the output format. Available formats are text, parseable, colorized, msvs

2
sysinv/sysinv/sysinv/sysinv/conductor/manager.py
View File

@ -5881,7 +5881,7 @@ class ConductorManager(service.PeriodicService):
# @staticmethod can't be used with @retry decorator below because
# it raises a "'staticmethod' object is not callable" exception
def _osd_must_be_down(result): # pylint: disable=no-self-argument
response, body = result
response, body = result # pylint: disable=unpacking-non-sequence
if not response.ok:
LOG.error("OSD remove failed: {}".format(body))
if (response.status_code == httplib.BAD_REQUEST and