config/12cae83703ba4036490c668d7d95d8a849f018cc

{
  "comments": [
    {
      "key": {
        "uuid": "b9f94d8f_8eb8484f",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 276,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "I assume this method never returns None",
      "range": {
        "startLine": 276,
        "startChar": 43,
        "endLine": 276,
        "endChar": 75
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "42110b82_a6710757",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 276,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "In case there\u0027s no entry on db it will return an empty list",
      "parentUuid": "b9f94d8f_8eb8484f",
      "range": {
        "startLine": 276,
        "startChar": 43,
        "endLine": 276,
        "endChar": 75
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "a58e70f4_0a5ef5fa",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 305,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "This would be clearer if you used \"if None\" or \"if not None\" for checking this value",
      "range": {
        "startLine": 305,
        "startChar": 19,
        "endLine": 305,
        "endChar": 38
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "fac94fcb_e84b5e2f",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 305,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "a58e70f4_0a5ef5fa",
      "range": {
        "startLine": 305,
        "startChar": 19,
        "endLine": 305,
        "endChar": 38
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "2048649e_638e0f52",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 306,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "Does this variable actually represent \u0027ever\u0027 or \u0027never\u0027  for how it is used?",
      "range": {
        "startLine": 306,
        "startChar": 25,
        "endLine": 306,
        "endChar": 31
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "8635d357_63a4e7da",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 306,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "would be \u0027never\u0027, because once an update starts, the host will be present on the database table tracking the host update",
      "parentUuid": "2048649e_638e0f52",
      "range": {
        "startLine": 306,
        "startChar": 25,
        "endLine": 306,
        "endChar": 31
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "bc82e452_e5b75f15",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 331,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "typo",
      "range": {
        "startLine": 331,
        "startChar": 51,
        "endLine": 331,
        "endChar": 54
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "4d2ad65c_e92a782f",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 331,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "bc82e452_e5b75f15",
      "range": {
        "startLine": 331,
        "startChar": 51,
        "endLine": 331,
        "endChar": 54
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1c72cd80_f5c2197e",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 359,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "Would we want this string to be declared a constant somewhere?",
      "range": {
        "startLine": 359,
        "startChar": 16,
        "endLine": 359,
        "endChar": 48
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "89fe63cb_ad9c0b9b",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 8
      },
      "lineNbr": 359,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "Done. Put in sysinv/common/constants.py. On posterior deliveries we\u0027ll have more constants and will be stored there too",
      "parentUuid": "1c72cd80_f5c2197e",
      "range": {
        "startLine": 359,
        "startChar": 16,
        "endLine": 359,
        "endChar": 48
      },
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "f156eee2_1afd53f7",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 8
      },
      "lineNbr": 13904,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "I would check with Bin to see if we have a third option now pertaining to AIO",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "005166f7_4b693aae",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 8
      },
      "lineNbr": 13904,
      "author": {
        "id": 28676
      },
      "writtenOn": "2021-06-01T20:04:32Z",
      "side": 1,
      "message": "\u003e I would check with Bin to see if we have a third option now pertaining to AIO\n\nHi Al, there seems to be a \"edgeworker\" node type added in R5. Is that what you refer to?",
      "parentUuid": "f156eee2_1afd53f7",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "32aae9a1_32ad3bc9",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 8
      },
      "lineNbr": 13904,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-02T12:06:00Z",
      "side": 1,
      "message": "My mistake. I was thinking of changes related to this submission, but it did not add a new type. https://review.opendev.org/c/starlingx/stx-puppet/+/780600",
      "parentUuid": "005166f7_4b693aae",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "f1974ac0_1b40de2c",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 8
      },
      "lineNbr": 13920,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "Is this log going to be dropped to debug or removed later?",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "bdabc059_c52832c7",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 8
      },
      "lineNbr": 13920,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-01T18:04:49Z",
      "side": 1,
      "message": "removed",
      "parentUuid": "f1974ac0_1b40de2c",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "d9c1df0a_8f059b99",
        "filename": "sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py",
        "patchSetId": 8
      },
      "lineNbr": 146,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-05-31T14:19:09Z",
      "side": 1,
      "message": "this indent is off",
      "revId": "12cae83703ba4036490c668d7d95d8a849f018cc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}