config/88e284f01ddf3f3f81baa0b75a01c900da7ba263

{
  "comments": [
    {
      "key": {
        "uuid": "fb363075_2b210aa3",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 19
      },
      "lineNbr": 391,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T17:40:35Z",
      "side": 1,
      "message": "generally, it is more robust to reference by uuid, however, since its derived locally, should be safe",
      "range": {
        "startLine": 391,
        "startChar": 22,
        "endLine": 391,
        "endChar": 24
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e798b2dd_cb152bed",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 19
      },
      "lineNbr": 391,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "fb363075_2b210aa3",
      "range": {
        "startLine": 391,
        "startChar": 22,
        "endLine": 391,
        "endChar": 24
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "91267e3e_b5cdf86e",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/constants.py",
        "patchSetId": 19
      },
      "lineNbr": 1904,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T17:40:35Z",
      "side": 1,
      "message": "nit: would be more readable as \"trust-both-cas\"  etc... as appears to be the local convention here for splitting words",
      "range": {
        "startLine": 1904,
        "startChar": 33,
        "endLine": 1904,
        "endChar": 45
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e8b8b269_e8afb2c2",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/constants.py",
        "patchSetId": 19
      },
      "lineNbr": 1904,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:47Z",
      "side": 1,
      "message": "changed.",
      "parentUuid": "91267e3e_b5cdf86e",
      "range": {
        "startLine": 1904,
        "startChar": 33,
        "endLine": 1904,
        "endChar": 45
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "86441463_7ab9240e",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 19
      },
      "lineNbr": 7537,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T17:40:35Z",
      "side": 1,
      "message": "is check_pending_app_reapply() required in each of these 3 cases?",
      "range": {
        "startLine": 7537,
        "startChar": 16,
        "endLine": 7537,
        "endChar": 30
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "4c6665c2_b8b96a34",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 19
      },
      "lineNbr": 7537,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:47Z",
      "side": 1,
      "message": "Hi John, I think this case is being considered if one of those cases happens, I understood your question right?\nLike we are just following the method logic, based on other \u0027if\u0027 cases",
      "parentUuid": "86441463_7ab9240e",
      "range": {
        "startLine": 7537,
        "startChar": 16,
        "endLine": 7537,
        "endChar": 30
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "bd85212e_cdaf2093",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 19
      },
      "lineNbr": 13997,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T17:40:35Z",
      "side": 1,
      "message": "The config_uuid update here could leave the config out of date if the phase check raises and exception.  Can these phase checks be done beforehand, perhaps in the api instead so that it is before any hieradata affecting updates?  As this is an asynchronous call, so should verify that this code can be reentrant (ie. after an interruption/failure to kube_certificate_update_by_host()).",
      "range": {
        "startLine": 13994,
        "startChar": 7,
        "endLine": 13997,
        "endChar": 0
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "069c9c5d_59e0c8cf",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 19
      },
      "lineNbr": 13997,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:47Z",
      "side": 1,
      "message": "Hi John, I moved phase check to API. Thanks for the suggestion.",
      "parentUuid": "bd85212e_cdaf2093",
      "range": {
        "startLine": 13994,
        "startChar": 7,
        "endLine": 13997,
        "endChar": 0
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "a96c4cce_ed443b7f",
        "filename": "sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py",
        "patchSetId": 19
      },
      "lineNbr": 147,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T17:40:35Z",
      "side": 1,
      "message": "this appears to be a debug log to be removed?",
      "range": {
        "startLine": 147,
        "startChar": 22,
        "endLine": 147,
        "endChar": 27
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "26cd7f00_f4bcdd4a",
        "filename": "sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py",
        "patchSetId": 19
      },
      "lineNbr": 147,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "a96c4cce_ed443b7f",
      "range": {
        "startLine": 147,
        "startChar": 22,
        "endLine": 147,
        "endChar": 27
      },
      "revId": "88e284f01ddf3f3f81baa0b75a01c900da7ba263",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}