config/a43bdedcafc08e9f688387e0319c0d4351af50bf

{
  "comments": [
    {
      "key": {
        "uuid": "d469ccbf_fa15c4d7",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 17
      },
      "lineNbr": 62,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "OK, this looks good since save_kubernetes_rootca_cert returns the appropriate structure",
      "range": {
        "startLine": 62,
        "startChar": 15,
        "endLine": 62,
        "endChar": 21
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "6b9a1c9a_f08feb0a",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 17
      },
      "lineNbr": 62,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-17T17:36:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "d469ccbf_fa15c4d7",
      "range": {
        "startLine": 62,
        "startChar": 15,
        "endLine": 62,
        "endChar": 21
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "30da6dad_c328b5a9",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 17
      },
      "lineNbr": 118,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "I do not actually see where this \u0027upload\u0027 is being used",
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "a0cacfd2_10b5416f",
        "filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_rootca_update.py",
        "patchSetId": 17
      },
      "lineNbr": 118,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-17T17:36:47Z",
      "side": 1,
      "message": "Hi Al, this is being used to allow pecan to have access to route \"/v1/kube_rootca_update/upload\", same functionality of the objects assigned in class V1 in _init_.py",
      "parentUuid": "30da6dad_c328b5a9",
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "d74ba765_3f6538d5",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/kubernetes.py",
        "patchSetId": 17
      },
      "lineNbr": 588,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "these indents appear to be off by 1",
      "range": {
        "startLine": 584,
        "startChar": 64,
        "endLine": 588,
        "endChar": 68
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "6ee7fb52_3e20350b",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2575,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "I dont mind these, but since you are never changing either of these marker variables, why not just use the constants directly in the code below",
      "range": {
        "startLine": 2574,
        "startChar": 4,
        "endLine": 2575,
        "endChar": 49
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "b32db3b4_3974cf45",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2575,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-17T17:36:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "6ee7fb52_3e20350b",
      "range": {
        "startLine": 2574,
        "startChar": 4,
        "endLine": 2575,
        "endChar": 49
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "4d91233d_e5333282",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2582,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "Doesnt find return -1 if not found.  So wouldnt this always evaluate to \u003e 0\n-1 + len(something)",
      "range": {
        "startLine": 2582,
        "startChar": 46,
        "endLine": 2582,
        "endChar": 63
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "a12049db_fdb72586",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2582,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-17T17:36:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "4d91233d_e5333282",
      "range": {
        "startLine": 2582,
        "startChar": 46,
        "endLine": 2582,
        "endChar": 63
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "86fb8344_cb017408",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2605,
      "author": {
        "id": 15435
      },
      "writtenOn": "2021-06-16T22:17:46Z",
      "side": 1,
      "message": "same comment as above",
      "range": {
        "startLine": 2605,
        "startChar": 45,
        "endLine": 2605,
        "endChar": 63
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "fb47b5f5_bdaa49af",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 17
      },
      "lineNbr": 2605,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-17T17:36:47Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "86fb8344_cb017408",
      "range": {
        "startLine": 2605,
        "startChar": 45,
        "endLine": 2605,
        "endChar": 63
      },
      "revId": "a43bdedcafc08e9f688387e0319c0d4351af50bf",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}