config/eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278

{
  "comments": [
    {
      "key": {
        "uuid": "2ca4f167_0f1ad74e",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 9
      },
      "lineNbr": 2575,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T15:50:49Z",
      "side": 1,
      "message": "should be defined as constants as referred in method below as well",
      "range": {
        "startLine": 2574,
        "startChar": 1,
        "endLine": 2575,
        "endChar": 49
      },
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "c2df4627_eba51b5c",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 9
      },
      "lineNbr": 2575,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:34Z",
      "side": 1,
      "message": "moved to constants.py",
      "parentUuid": "2ca4f167_0f1ad74e",
      "range": {
        "startLine": 2574,
        "startChar": 1,
        "endLine": 2575,
        "endChar": 49
      },
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "3761f5f3_e67a5b6d",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 9
      },
      "lineNbr": 13810,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T15:50:49Z",
      "side": 1,
      "message": "this method is already getting large, consider factoring this into separate method(s)",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "da018b3b_d8da9d63",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 9
      },
      "lineNbr": 13810,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:34Z",
      "side": 1,
      "message": "Made _create_kube_rootca_resources() to gather the rootca secret and issuer creation and _precheck_save_kubernetes_rootca_cert() for validation of the procedure phase and uploaded certificate",
      "parentUuid": "3761f5f3_e67a5b6d",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "ec0632ed_95a348f4",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 9
      },
      "lineNbr": 13828,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T15:50:49Z",
      "side": 1,
      "message": "can this code be indempotent/reentrant ? - ie. if it fails during this state, can it rerun again and succeed. i.e. it may have already created the secret, but needs to continue with remainder of this method.",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "4b8177aa_57d8b9fb",
        "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
        "patchSetId": 9
      },
      "lineNbr": 13828,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:34Z",
      "side": 1,
      "message": "You\u0027re right John. What I did here as a fix was to add a check: if the secret already exists we delete it and then create the one we want, overwritting it. In case the creation fails, the kube_create_secret() method will throw an Exception signalizing the error",
      "parentUuid": "ec0632ed_95a348f4",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "a387c3fa_907083e7",
        "filename": "sysinv/sysinv/sysinv/sysinv/tests/api/test_kube_rootca_update.py",
        "patchSetId": 9
      },
      "lineNbr": 39,
      "author": {
        "id": 9926
      },
      "writtenOn": "2021-06-15T15:50:49Z",
      "side": 1,
      "message": "remove commented out code if not needed",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e4d2573b_5855e269",
        "filename": "sysinv/sysinv/sysinv/sysinv/tests/api/test_kube_rootca_update.py",
        "patchSetId": 9
      },
      "lineNbr": 39,
      "author": {
        "id": 32877
      },
      "writtenOn": "2021-06-16T20:08:34Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "a387c3fa_907083e7",
      "revId": "eef2bc4e8ab96ba48f1a23468c1c6b9e8806f278",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}