bc04c7624e
Importing the appropriate oslo utility classes. This allows the removal of: sysinv.openstack.common.cliutils (unused) sysinv.openstack.common.excutils sysinv.openstack.common.fileutils sysinv.openstack.common.importutils sysinv.openstack.common.jsonutils sysinv.openstack.common.network_utils sysinv.openstack.common.processutils (unused) sysinv.openstack.common.strutils sysinv.openstack.common.timeutils Note: strutils had a method signature change. Note: unit tests that referenced fileutils were updated based on similar changes in ironic (icehouse timeframe) requirements.txt changes: - jsonutils.py was the only file importing 'anyjson'. Note: anyjson is still installed on the nodes, due to a requirement by kombu. It will be opportunistically used by oslo.serialization/jsonutils when detected. Change-Id: Ic796e1984caf1b88fe0806099a3ca9e9e625095e Story: 2006796 Task: 37359 Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
110 lines
3.7 KiB
Python
110 lines
3.7 KiB
Python
# Vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
# coding=utf-8
|
|
|
|
# Copyright 2013 Hewlett-Packard Development Company, L.P.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
import fixtures
|
|
|
|
from oslo_utils import excutils
|
|
from sysinv.common import exception
|
|
from sysinv.common import images
|
|
from sysinv.tests import base
|
|
|
|
|
|
class SysinvImagesTestCase(base.TestCase):
|
|
def test_fetch_raw_image(self):
|
|
|
|
def fake_execute(*cmd, **kwargs):
|
|
self.executes.append(cmd)
|
|
return None, None
|
|
|
|
def fake_rename(old, new):
|
|
self.executes.append(('mv', old, new))
|
|
|
|
def fake_unlink(path):
|
|
self.executes.append(('rm', path))
|
|
|
|
@contextlib.contextmanager
|
|
def fake_rm_on_error(path):
|
|
try:
|
|
yield
|
|
except Exception:
|
|
with excutils.save_and_reraise_exception():
|
|
fake_del_if_exists(path)
|
|
|
|
def fake_del_if_exists(path):
|
|
self.executes.append(('rm', '-f', path))
|
|
|
|
def fake_qemu_img_info(path):
|
|
class FakeImgInfo(object):
|
|
pass
|
|
|
|
file_format = path.split('.')[-1]
|
|
if file_format == 'part':
|
|
file_format = path.split('.')[-2]
|
|
elif file_format == 'converted':
|
|
file_format = 'raw'
|
|
if 'backing' in path:
|
|
backing_file = 'backing'
|
|
else:
|
|
backing_file = None
|
|
|
|
FakeImgInfo.file_format = file_format
|
|
FakeImgInfo.backing_file = backing_file
|
|
|
|
return FakeImgInfo()
|
|
|
|
self.stub_out('sysinv.common.utils.execute', fake_execute)
|
|
self.stub_out('os.rename', fake_rename)
|
|
self.stub_out('os.unlink', fake_unlink)
|
|
self.stub_out('sysinv.common.images.fetch', lambda *_: None)
|
|
self.stub_out('sysinv.common.images.qemu_img_info', fake_qemu_img_info)
|
|
self.useFixture(fixtures.MonkeyPatch(
|
|
'oslo_utils.fileutils.remove_path_on_error',
|
|
fake_rm_on_error))
|
|
self.useFixture(fixtures.MonkeyPatch(
|
|
'oslo_utils.fileutils.delete_if_exists',
|
|
fake_del_if_exists))
|
|
|
|
context = 'opaque context'
|
|
image_id = '4'
|
|
|
|
target = 't.qcow2'
|
|
self.executes = []
|
|
expected_commands = [('qemu-img', 'convert', '-O', 'raw',
|
|
't.qcow2.part', 't.qcow2.converted'),
|
|
('rm', 't.qcow2.part'),
|
|
('mv', 't.qcow2.converted', 't.qcow2')]
|
|
images.fetch_to_raw(context, image_id, target)
|
|
self.assertEqual(self.executes, expected_commands)
|
|
|
|
target = 't.raw'
|
|
self.executes = []
|
|
expected_commands = [('mv', 't.raw.part', 't.raw')]
|
|
images.fetch_to_raw(context, image_id, target)
|
|
self.assertEqual(self.executes, expected_commands)
|
|
|
|
target = 'backing.qcow2'
|
|
self.executes = []
|
|
expected_commands = [('rm', '-f', 'backing.qcow2.part')]
|
|
self.assertRaises(exception.ImageUnacceptable,
|
|
images.fetch_to_raw,
|
|
context, image_id, target)
|
|
self.assertEqual(self.executes, expected_commands)
|
|
|
|
del self.executes
|