starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(3 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 35441 \u003c35441@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
This commit is contained in:
Gerrit User 31954 2024-05-06 18:17:53 +00:00 committed by Gerrit Code Review
parent 666032c399
commit 33d134fa56
2 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
f4c46c322b72910a0527cc74d84b4463143c315a
View File

@ -152,6 +152,30 @@
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d7b0d216_76e37993",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 6
},
"lineNbr": 575,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T18:17:53Z",
"side": 1,
"message": "Expect the process of the parsed_args.bmc_password and install values as expected here",
"parentUuid": "325ddafa_42ad3705",
"range": {
"startLine": 575,
"startChar": 8,
"endLine": 575,
"endChar": 22
},
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -175,6 +199,30 @@
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "aba0bb02_d2eb7ca8",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 265,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T18:17:53Z",
"side": 1,
"message": "Yes, need backward compatibility starting from the next release, suggest:\n1 keeping the current option here though may not used in the next release, and ignore it for now in the backend\n2 Or adding a semantic check to reject the coexistence of the release and enroll option(and we can simply remove the check if necessary)",
"parentUuid": "5c135e49_60b08a1d",
"range": {
"startLine": 259,
"startChar": 8,
"endLine": 265,
"endChar": 9
},
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

18
f83fe08336349267b7b2d09638cf7ab9eb90a55f
View File

@ -235,6 +235,24 @@
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a38eeb2c_5ba5ce33",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T18:17:53Z",
"side": 1,
"message": "We\u0027ll need the bmc address and bmc password to make a request to the bmc controller to feed the seed iso",
"parentUuid": "768b908c_58e88e21",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {