starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(4 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
This commit is contained in:
Gerrit User 36476 2024-05-03 19:53:18 +00:00 committed by Gerrit Code Review
parent 23d311d81f
commit cb3c3785fb
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
65133da89bea9e3e39e11b6c455ae042c78c06de Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "ae87f78a_30863ddf",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 36476
},
"writtenOn": "2024-05-03T19:53:18Z",
"side": 1,
"message": "Remember to line break to make sure the message is consistent",
"range": {
"startLine": 10,
"startChar": 0,
"endLine": 11,
"endChar": 11
},
"revId": "65133da89bea9e3e39e11b6c455ae042c78c06de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "830b95f1_cfe17a5d",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_patch_manager.py",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 36476
},
"writtenOn": "2024-05-03T19:53:18Z",
"side": 1,
"message": "I know this is not related to your task, but can you improve this to:\n\n```\nkwargs_dict[\"upload-only\"] \u003d True if parsed_args.upload_only else False\n```",
"range": {
"startLine": 75,
"startChar": 0,
"endLine": 77,
"endChar": 48
},
"revId": "65133da89bea9e3e39e11b6c455ae042c78c06de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "83017ded_b9aa8bef",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_patch_update_strategy.py",
"patchSetId": 1
},
"lineNbr": 64,
"author": {
"id": 36476
},
"writtenOn": "2024-05-03T19:53:18Z",
"side": 1,
"message": "Just to double check, are all the new conditions covered in the test when you ran tox with the cover option? I believe so, but I want to confirm that we are not lowering the coverage.",
"revId": "65133da89bea9e3e39e11b6c455ae042c78c06de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dc79d19f_ba63b9f0",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_patch_update_strategy.py",
"patchSetId": 1
},
"lineNbr": 75,
"author": {
"id": 36476
},
"writtenOn": "2024-05-03T19:53:18Z",
"side": 1,
"message": "With exception of strategy, these variables are duplicated in the tests. We could move them to setup to clean up",
"range": {
"startLine": 68,
"startChar": 0,
"endLine": 75,
"endChar": 73
},
"revId": "65133da89bea9e3e39e11b6c455ae042c78c06de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}